Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 2526163002: Rename blink::Page's load deferral to suspension (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, Yoav Weiss, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, loading-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename blink::Page's load deferral to suspension This CL renames: * ScopedPageLoadDeferrer to ScopedPageSuspender, * blink::Page::defersLoading() to suspended(), and * blink::Page::setDefersLoading() to setSuspended(). blink::setDefersLoading does not only defer loadings, but also suspends all associated ExecutionContext and ActiveDOMObjects. Committed: https://crrev.com/5ad6641ca96fc131e8268f649bc6db71170ad736 Cr-Commit-Position: refs/heads/master@{#434378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -202 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ScopedPageSuspender.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 3 chunks +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-11-24 05:45:15 UTC) #5
haraken
LGTM
4 years ago (2016-11-24 06:28:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526163002/1
4 years ago (2016-11-24 17:25:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 19:06:25 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-24 19:07:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ad6641ca96fc131e8268f649bc6db71170ad736
Cr-Commit-Position: refs/heads/master@{#434378}

Powered by Google App Engine
This is Rietveld 408576698