Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 2526163002: Rename blink::Page's load deferral to suspension (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
index 75871b8220ef7dab1b9b8713f357ee61ce2b9385..034bde6eb59ccb71de9313dc56472f3e1c98a807 100644
--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
@@ -267,15 +267,15 @@ class CreateWindowTest : public testing::Test {
Persistent<ChromeClientImpl> m_chromeClientImpl;
};
-TEST_F(CreateWindowTest, CreateWindowFromDeferredPage) {
- m_webView->page()->setDefersLoading(true);
+TEST_F(CreateWindowTest, CreateWindowFromSuspendedPage) {
+ m_webView->page()->setSuspended(true);
LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame();
FrameLoadRequest request(frame->document());
WindowFeatures features;
EXPECT_EQ(nullptr,
m_chromeClientImpl->createWindow(frame, request, features,
NavigationPolicyNewForegroundTab));
- m_webView->page()->setDefersLoading(false);
+ m_webView->page()->setSuspended(false);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698