Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2526163002: Rename blink::Page's load deferral to suspension (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 360
361 } // namespace 361 } // namespace
362 362
363 Page* ChromeClientImpl::createWindow(LocalFrame* frame, 363 Page* ChromeClientImpl::createWindow(LocalFrame* frame,
364 const FrameLoadRequest& r, 364 const FrameLoadRequest& r,
365 const WindowFeatures& features, 365 const WindowFeatures& features,
366 NavigationPolicy navigationPolicy) { 366 NavigationPolicy navigationPolicy) {
367 if (!m_webView->client()) 367 if (!m_webView->client())
368 return nullptr; 368 return nullptr;
369 369
370 if (!frame->page() || frame->page()->defersLoading()) 370 if (!frame->page() || frame->page()->suspended())
371 return nullptr; 371 return nullptr;
372 372
373 WebNavigationPolicy policy = 373 WebNavigationPolicy policy =
374 effectiveNavigationPolicy(navigationPolicy, features); 374 effectiveNavigationPolicy(navigationPolicy, features);
375 DCHECK(frame->document()); 375 DCHECK(frame->document());
376 Fullscreen::fullyExitFullscreen(*frame->document()); 376 Fullscreen::fullyExitFullscreen(*frame->document());
377 377
378 WebViewImpl* newView = toWebViewImpl(m_webView->client()->createView( 378 WebViewImpl* newView = toWebViewImpl(m_webView->client()->createView(
379 WebLocalFrameImpl::fromFrame(frame), 379 WebLocalFrameImpl::fromFrame(frame),
380 WrappedResourceRequest(r.resourceRequest()), features, r.frameName(), 380 WrappedResourceRequest(r.resourceRequest()), features, r.frameName(),
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
1165 if (RuntimeEnabledFeatures::presentationEnabled()) 1165 if (RuntimeEnabledFeatures::presentationEnabled())
1166 PresentationController::provideTo(frame, client->presentationClient()); 1166 PresentationController::provideTo(frame, client->presentationClient());
1167 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) 1167 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
1168 provideAudioOutputDeviceClientTo(frame, 1168 provideAudioOutputDeviceClientTo(frame,
1169 AudioOutputDeviceClientImpl::create()); 1169 AudioOutputDeviceClientImpl::create());
1170 if (RuntimeEnabledFeatures::installedAppEnabled()) 1170 if (RuntimeEnabledFeatures::installedAppEnabled())
1171 InstalledAppController::provideTo(frame, client->installedAppClient()); 1171 InstalledAppController::provideTo(frame, client->installedAppClient());
1172 } 1172 }
1173 1173
1174 } // namespace blink 1174 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698