Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 2526163002: Rename blink::Page's load deferral to suspension (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 260
261 void TearDown() override { m_webView->close(); } 261 void TearDown() override { m_webView->close(); }
262 262
263 ViewCreatingClient m_webViewClient; 263 ViewCreatingClient m_webViewClient;
264 WebViewImpl* m_webView; 264 WebViewImpl* m_webView;
265 WebLocalFrame* m_mainFrame; 265 WebLocalFrame* m_mainFrame;
266 FrameTestHelpers::TestWebFrameClient m_webFrameClient; 266 FrameTestHelpers::TestWebFrameClient m_webFrameClient;
267 Persistent<ChromeClientImpl> m_chromeClientImpl; 267 Persistent<ChromeClientImpl> m_chromeClientImpl;
268 }; 268 };
269 269
270 TEST_F(CreateWindowTest, CreateWindowFromDeferredPage) { 270 TEST_F(CreateWindowTest, CreateWindowFromSuspendedPage) {
271 m_webView->page()->setDefersLoading(true); 271 m_webView->page()->setSuspended(true);
272 LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame(); 272 LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame();
273 FrameLoadRequest request(frame->document()); 273 FrameLoadRequest request(frame->document());
274 WindowFeatures features; 274 WindowFeatures features;
275 EXPECT_EQ(nullptr, 275 EXPECT_EQ(nullptr,
276 m_chromeClientImpl->createWindow(frame, request, features, 276 m_chromeClientImpl->createWindow(frame, request, features,
277 NavigationPolicyNewForegroundTab)); 277 NavigationPolicyNewForegroundTab));
278 m_webView->page()->setDefersLoading(false); 278 m_webView->page()->setSuspended(false);
279 } 279 }
280 280
281 } // namespace blink 281 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698