Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.cpp

Issue 2526163002: Rename blink::Page's load deferral to suspension (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.cpp
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.cpp b/third_party/WebKit/Source/core/page/ChromeClient.cpp
index 5184b74ece32c83f25e0dc7f5a9687388b6680df..e1bc2306f4a1029dc9887b4374e5f40d31e65361 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.cpp
+++ b/third_party/WebKit/Source/core/page/ChromeClient.cpp
@@ -29,7 +29,7 @@
#include "core/inspector/InspectorInstrumentation.h"
#include "core/layout/HitTestResult.h"
#include "core/page/FrameTree.h"
-#include "core/page/ScopedPageLoadDeferrer.h"
+#include "core/page/ScopedPageSuspender.h"
#include "core/page/WindowFeatures.h"
#include "platform/geometry/IntRect.h"
#include "platform/network/NetworkHints.h"
@@ -90,10 +90,10 @@ static bool openJavaScriptDialog(LocalFrame* frame,
const String& message,
ChromeClient::DialogType dialogType,
const Delegate& delegate) {
- // Defer loads in case the client method runs a new event loop that would
+ // Suspend pages in case the client method runs a new event loop that would
// otherwise cause the load to continue while we're in the middle of
// executing JavaScript.
- ScopedPageLoadDeferrer deferrer;
+ ScopedPageSuspender suspender;
InspectorInstrumentation::willRunJavaScriptDialog(frame, message, dialogType);
bool result = delegate();
InspectorInstrumentation::didRunJavaScriptDialog(frame, result);
@@ -209,10 +209,10 @@ bool ChromeClient::print(LocalFrame* frame) {
return false;
}
- // Defer loads in case the client method runs a new event loop that would
+ // Suspend pages in case the client method runs a new event loop that would
// otherwise cause the load to continue while we're in the middle of
// executing JavaScript.
- ScopedPageLoadDeferrer deferrer;
+ ScopedPageSuspender suspender;
printDelegate(frame);
return true;
« no previous file with comments | « third_party/WebKit/Source/core/page/BUILD.gn ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698