Deprecate NGPhysicalConstraintSpace

Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can be only created via its builder.
5) Switching between inline/block happens in NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if there is no parent_space or when a new FC is established.

BUG=635619
Committed: https://crrev.com/3d12834fa3981ef5f09b4c207c7cc17c56f5069f
Cr-Commit-Position: refs/heads/master@{#435712}

[Gleb Lanbin, 2016-11-23 17:17:11]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-11-23 17:18:59]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2016-11-23 17:19:18]

Description was changed from

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
3) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
4) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619
==========

to

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619
==========

[Gleb Lanbin, 2016-11-23 17:19:26]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:19:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:38:27]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[ikilpatrick, 2016-11-23 17:40:38]

very quick pass :)

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:94: bool
SetIsInlineDirectionTriggersScrollbar(
we don't need the setters any more?

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:141:
NGConstraintSpace* ChildSpace(const ComputedStyle* style) const;
I assume this method is going away, add todo?

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:13:
writing_mode_(parent_space->WritingMode()),
Only set the writing_mode_ and direction_ here?

I worry that we'll get subtle bugs if we copy everything from the parent, like
if fixed_inline is set for example.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:98: if
(writing_mode_ == HorizontalTopBottom) {
So if this is the current layout's writing mode, this will be wrong for the
child?

E.g. 
parent - tb-ltr
child - vertical-rl

May be clearer if ToConstraintSpace takes a writing mode argument?

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
(right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:41: }
.nit nl below this?

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:56: //
const bit fields.
remove this comment now?

[Gleb Lanbin, 2016-11-23 18:59:50]

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:94: bool
SetIsInlineDirectionTriggersScrollbar(
On 2016/11/23 17:40:38, ikilpatrick wrote:
> we don't need the setters any more?

Done.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:141:
NGConstraintSpace* ChildSpace(const ComputedStyle* style) const;
On 2016/11/23 17:40:38, ikilpatrick wrote:
> I assume this method is going away, add todo?

is it? I'm not aware about this. Can you provide a bit more details on this or I
can just fix it in this patch instead of adding one more TODO.
we can get rid of this helper method and use the builder instead. Although I'm
not sure if the original author of this method will agree with that.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:13:
writing_mode_(parent_space->WritingMode()),
On 2016/11/23 17:40:38, ikilpatrick wrote:
> Only set the writing_mode_ and direction_ here?
> 
> I worry that we'll get subtle bugs if we copy everything from the parent, like
> if fixed_inline is set for example.

Done.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:98: if
(writing_mode_ == HorizontalTopBottom) {
On 2016/11/23 17:40:38, ikilpatrick wrote:
> So if this is the current layout's writing mode, this will be wrong for the
> child?
> 
> E.g. 
> parent - tb-ltr
> child - vertical-rl
> 
> May be clearer if ToConstraintSpace takes a writing mode argument?

I would rather use the builder semantic here, i.e. if you need to change
writing_mode then use SetWritingMode.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
(right):

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:41: }
On 2016/11/23 17:40:38, ikilpatrick wrote:
> .nit nl below this?

Done.

https://codereview.chromium.org/2525033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:56: //
const bit fields.
On 2016/11/23 17:40:38, ikilpatrick wrote:
> remove this comment now?

Done.

[Gleb Lanbin, 2016-11-23 19:05:28]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 19:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:58:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ikilpatrick, 2016-11-23 20:05:25]

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:93:
exclusions_.reset(new NGExclusions());
you'll want to do this when you construct the constraint space, e.g.

new NGConstraintSpace(/* blah */, is_new_fc_ ? new NGExclusions() :
exclusions_);

or similar.

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:98: if
(writing_mode_ == HorizontalTopBottom) {
so you'll need to store an additional field parent_writing_mode_.

All of the fields on the builder will be set relative to the parents writing
mode. I.e.

SetAvailableSize(blah);

Here you'll need to do the check:

if ((parent_writing_mode_ == HorizontalTopBottom) == (writing_mode_ ==
HorizontalTopBottom)) {
  // Both are vertical or horizontal.
} else {
  // orthog. writing mode.
}

[Gleb Lanbin, 2016-11-28 23:54:02]

Patchset #3 (id:60001) has been deleted

[Gleb Lanbin, 2016-11-28 23:55:00]

thanks. PTAL

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:93:
exclusions_.reset(new NGExclusions());
On 2016/11/23 20:05:24, ikilpatrick wrote:
> you'll want to do this when you construct the constraint space, e.g.
> 
> new NGConstraintSpace(/* blah */, is_new_fc_ ? new NGExclusions() :
> exclusions_);
> 
> or similar.
> 

Done.

https://codereview.chromium.org/2525033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:98: if
(writing_mode_ == HorizontalTopBottom) {
On 2016/11/23 20:05:24, ikilpatrick wrote:
> so you'll need to store an additional field parent_writing_mode_.
> 
> All of the fields on the builder will be set relative to the parents writing
> mode. I.e.
> 
> SetAvailableSize(blah);
> 
> Here you'll need to do the check:
> 
> if ((parent_writing_mode_ == HorizontalTopBottom) == (writing_mode_ ==
> HorizontalTopBottom)) {
>   // Both are vertical or horizontal.
> } else {
>   // orthog. writing mode.
> }

Done.

[ikilpatrick, 2016-11-29 00:10:28]

\o/ lgtm

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:73: void
SetOffset(const NGLogicalOffset& offset) { offset_ = offset; }
.nit? (up to you)

TODO: remove.

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:15:
is_fixed_size_inline_(parent_space->IsFixedSizeInline()),
for most of these we may want to set them to defaults to make sure we fail early
if we are using something accidently, but can be done later.

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:102: //
Example: vertical-rl and vertical-lr
nice comment. :)

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
(right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:39:
writing_mode_ = writing_mode;
.nit? move to cc file? up to you.

[Gleb Lanbin, 2016-11-29 00:32:56]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:34:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:36:07]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Gleb Lanbin, 2016-12-01 03:28:05]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 03:28:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 03:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 03:30:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Gleb Lanbin, 2016-12-01 05:09:38]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 05:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 06:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 06:13:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2016-12-01 18:45:16]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:36:23]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-12-01 20:41:53]

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:73: void
SetOffset(const NGLogicalOffset& offset) { offset_ = offset; }
On 2016/11/29 00:10:27, ikilpatrick wrote:
> .nit? (up to you)
> 
> TODO: remove.

Done.

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:15:
is_fixed_size_inline_(parent_space->IsFixedSizeInline()),
On 2016/11/29 00:10:27, ikilpatrick wrote:
> for most of these we may want to set them to defaults to make sure we fail
early
> if we are using something accidently, but can be done later.

Done.

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:102: //
Example: vertical-rl and vertical-lr
On 2016/11/29 00:10:27, ikilpatrick wrote:
> nice comment. :)

Acknowledged.

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
(right):

https://codereview.chromium.org/2525033002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h:39:
writing_mode_ = writing_mode;
On 2016/11/29 00:10:27, ikilpatrick wrote:
> .nit? move to cc file? up to you.

Done.

[Gleb Lanbin, 2016-12-01 20:42:00]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-12-01 20:42:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2525033002/#ps180001
(title: "update TestExpectations")

[commit-bot: I haz the power, 2016-12-01 20:42:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:53:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Gleb Lanbin, 2016-12-01 20:56:45]

glebl@chromium.org changed reviewers:
+ dpranke@chromium.org

[Gleb Lanbin, 2016-12-01 20:57:28]

On 2016/12/01 20:56:50, Gleb Lanbin wrote:

Dirk, could you lgtm build.gn file?

[Dirk Pranke, 2016-12-01 20:59:16]

lgtm

[Gleb Lanbin, 2016-12-01 21:01:08]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:09:14]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1480626068406990,
"parent_rev": "df9e40400cb44902eeb768eab7297c9a0a3ea379", "commit_rev":
"d1f0a32d7218f5a2ddc5a6db16e3e46a982a4989"}

[commit-bot: I haz the power, 2016-12-01 21:09:44]

Description was changed from

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619
==========

to

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619
==========

[commit-bot: I haz the power, 2016-12-01 21:09:46]

Committed patchset #8 (id:180001)

[cbiesinger, 2016-12-01 21:11:36]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2016-12-01 21:11:37]

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:100: //
TODO(layoutng): Use builder.ToConstraintSpace.ToLogicalConstraintSpace
This TODO can be removed now.

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:15:
is_fixed_size_inline_(false),
Why not copy these values? This isn't really a "parent" space in the callers, is
it? This constructor is just used to flip the writing modes, and thus should
copy everything, no?

[commit-bot: I haz the power, 2016-12-01 21:11:56]

Description was changed from

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619
==========

to

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619

Committed: https://crrev.com/3d12834fa3981ef5f09b4c207c7cc17c56f5069f
Cr-Commit-Position: refs/heads/master@{#435712}
==========

[commit-bot: I haz the power, 2016-12-01 21:11:58]

Patchset 8 (id:??) landed as
https://crrev.com/3d12834fa3981ef5f09b4c207c7cc17c56f5069f
Cr-Commit-Position: refs/heads/master@{#435712}

[Gleb Lanbin, 2016-12-05 17:46:53]

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:100: //
TODO(layoutng): Use builder.ToConstraintSpace.ToLogicalConstraintSpace
On 2016/12/01 21:11:37, cbiesinger wrote:
> This TODO can be removed now.

done http://crrev.com/2557463002

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
(right):

https://codereview.chromium.org/2525033002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc:15:
is_fixed_size_inline_(false),
On 2016/12/01 21:11:37, cbiesinger wrote:
> Why not copy these values? This isn't really a "parent" space in the callers,
is
> it? This constructor is just used to flip the writing modes, and thus should
> copy everything, no?

per Ian's comment from https://codereview.chromium.org/2525033002/#msg35 this
was changed to use the default values

[Gleb Lanbin, 2016-12-05 17:47:07]

Description was changed from

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619

Committed: https://crrev.com/3d12834fa3981ef5f09b4c207c7cc17c56f5069f
Cr-Commit-Position: refs/heads/master@{#435712}
==========

to

==========
Deprecate NGPhysicalConstraintSpace

This patch deprecates NGPhysicalConstraintSpace and changes the LayoutNG code to
use NGConstraintSpace and its builder everywhere instead.

List of changes:
1) NGConstraintSpaceBuilder::ToConstraintSpace returns NGConstraintSpace
2) NGPhysicalConstraintSpace is removed
3) Introduced NGExclusions to store the list of exclusions and last left/right
floating exclusions.
4) NGConstraintSpace constructor is moved to private, so NGConstraintSpace can
be only created via its builder.
5) Switching between inline/block happens in
NGConstraintSpaceBuilder::ToConstraintSpace
6) Exclusions is shared with shared_ptr. A new exclusions list is created if
there is no parent_space or when a new FC is established.

BUG=635619

Committed: https://crrev.com/3d12834fa3981ef5f09b4c207c7cc17c56f5069f
Cr-Commit-Position: refs/heads/master@{#435712}
==========

[Gleb Lanbin, 2016-12-05 17:47:07]

glebl@chromium.org changed reviewers:
- dpranke@chromium.org