Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

Issue 2525033002: Deprecate NGPhysicalConstraintSpace (Closed)
Patch Set: update TestExpectations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
index d2905ffae097a3500d27f259c954edac80bc0df6..94113390fe3eb3e58071d9db1ec792d91af0c4ee 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
@@ -26,18 +26,19 @@ class NGAbsoluteUtilsTest : public ::testing::Test {
style_->setBoxSizing(EBoxSizing::BoxSizingBorderBox);
container_size_ = NGLogicalSize(LayoutUnit(200), LayoutUnit(300));
NGConstraintSpaceBuilder builder(kHorizontalTopBottom);
- ltr_space_ = new NGConstraintSpace(
- kHorizontalTopBottom, LTR,
- builder.SetAvailableSize(container_size_).ToConstraintSpace());
- rtl_space_ = new NGConstraintSpace(
- kHorizontalTopBottom, RTL,
- builder.SetAvailableSize(container_size_).ToConstraintSpace());
- vertical_lr_space_ = new NGConstraintSpace(
- kVerticalLeftRight, LTR,
- builder.SetAvailableSize(container_size_).ToConstraintSpace());
- vertical_rl_space_ = new NGConstraintSpace(
- kVerticalLeftRight, LTR,
- builder.SetAvailableSize(container_size_).ToConstraintSpace());
+ builder.SetAvailableSize(container_size_);
+ ltr_space_ = builder.SetWritingMode(kHorizontalTopBottom)
+ .SetTextDirection(LTR)
+ .ToConstraintSpace();
+ rtl_space_ = builder.SetWritingMode(kHorizontalTopBottom)
+ .SetTextDirection(RTL)
+ .ToConstraintSpace();
+ vertical_lr_space_ = builder.SetWritingMode(kVerticalLeftRight)
+ .SetTextDirection(LTR)
+ .ToConstraintSpace();
+ vertical_rl_space_ = builder.SetWritingMode(kVerticalLeftRight)
+ .SetTextDirection(LTR)
+ .ToConstraintSpace();
}
void SetHorizontalStyle(LayoutUnit left,

Powered by Google App Engine
This is Rietveld 408576698