Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

Issue 2525033002: Deprecate NGPhysicalConstraintSpace (Closed)
Patch Set: update TestExpectations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc
index 429a9d312bec3c0d499511c0bbb870710a839bb9..647d1dbdfe3c5336155bebb2b789edfa294fa372 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc
@@ -209,9 +209,10 @@ bool NGInlineNode::Layout(const NGConstraintSpace* constraint_space,
// NOTE: We don't need to change the coordinate system here as we are an
// inline.
- NGConstraintSpace* child_constraint_space = new NGConstraintSpace(
- constraint_space->WritingMode(), constraint_space->Direction(),
- constraint_space->MutablePhysicalSpace());
+ NGConstraintSpace* child_constraint_space =
+ NGConstraintSpaceBuilder(constraint_space->WritingMode())
+ .SetTextDirection(constraint_space->Direction())
+ .ToConstraintSpace();
if (!layout_algorithm_)
// TODO(layout-dev): If an atomic inline run the appropriate algorithm.

Powered by Google App Engine
This is Rietveld 408576698