Deprecate NGPhysicalConstraintSpace

third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_block_node.h"
 
 #include "core/layout/LayoutBlockFlow.h"
 #include "core/layout/api/LineLayoutAPIShim.h"
 #include "core/layout/line/InlineIterator.h"
 #include "core/layout/ng/layout_ng_block_flow.h"
@@ skipping 79 matching lines @@
   }
   DCHECK(!layout_coordinator_)
       << "Can't interleave Layout and ComputeMinAndMaxContentSizes";
   if (!minmax_algorithm_) {
     NGConstraintSpaceBuilder builder(
         FromPlatformWritingMode(Style()->getWritingMode()));
 
     builder.SetAvailableSize(NGLogicalSize(LayoutUnit(), LayoutUnit()));
     builder.SetPercentageResolutionSize(
         NGLogicalSize(LayoutUnit(), LayoutUnit()));
     // TODO(layoutng): Use builder.ToConstraintSpace.ToLogicalConstraintSpace

[cbiesinger, 2016/12/01 21:11:37]

This TODO can be removed now.

[Gleb Lanbin, 2016/12/05 17:46:53]

done http://crrev.com/2557463002

     // once
     // that's available.
-    NGConstraintSpace* constraint_space = new NGConstraintSpace(
-        FromPlatformWritingMode(Style()->getWritingMode()),
-        Style()->direction(), builder.ToConstraintSpace());
+    NGConstraintSpace* constraint_space =
+        NGConstraintSpaceBuilder(
+            FromPlatformWritingMode(Style()->getWritingMode()))
+            .SetTextDirection(Style()->direction())
+            .ToConstraintSpace();
 
     minmax_algorithm_ = new NGBlockLayoutAlgorithm(
         Style(), toNGBlockNode(FirstChild()), constraint_space);
   }
   // TODO(cbiesinger): For orthogonal children, we need to always synthesize.
   NGLayoutAlgorithm::MinAndMaxState state =
       minmax_algorithm_->ComputeMinAndMaxContentSizes(sizes);
   if (state == NGLayoutAlgorithm::kSuccess)
     return true;
   if (state == NGLayoutAlgorithm::kPending)
     return false;
   DCHECK_EQ(state, NGLayoutAlgorithm::kNotImplemented);
 
   // TODO(cbiesinger): Replace the loops below with a state machine like in
   // Layout.
 
   // Have to synthesize this value.
   NGPhysicalFragmentBase* physical_fragment;
   while (!minmax_algorithm_->Layout(nullptr, &physical_fragment, nullptr))
     continue;
   NGFragment* fragment = new NGFragment(
       FromPlatformWritingMode(Style()->getWritingMode()), Style()->direction(),
       toNGPhysicalFragment(physical_fragment));
 
   sizes->min_content = fragment->InlineOverflow();
 
   // Now, redo with infinite space for max_content
-  NGConstraintSpaceBuilder builder(
-      FromPlatformWritingMode(Style()->getWritingMode()));
-  builder.SetAvailableSize(NGLogicalSize(LayoutUnit::max(), LayoutUnit()));
-  builder.SetPercentageResolutionSize(
-      NGLogicalSize(LayoutUnit(), LayoutUnit()));
   NGConstraintSpace* constraint_space =
-      new NGConstraintSpace(FromPlatformWritingMode(Style()->getWritingMode()),
-                            Style()->direction(), builder.ToConstraintSpace());
+      NGConstraintSpaceBuilder(
+          FromPlatformWritingMode(Style()->getWritingMode()))
+          .SetTextDirection(Style()->direction())
+          .SetAvailableSize({LayoutUnit::max(), LayoutUnit()})
+          .SetPercentageResolutionSize({LayoutUnit(), LayoutUnit()})
+          .ToConstraintSpace();
 
   minmax_algorithm_ = new NGBlockLayoutAlgorithm(
       Style(), toNGBlockNode(FirstChild()), constraint_space);
   while (!minmax_algorithm_->Layout(nullptr, &physical_fragment, nullptr))
     continue;
 
   fragment = new NGFragment(FromPlatformWritingMode(Style()->getWritingMode()),
                             Style()->direction(),
                             toNGPhysicalFragment(physical_fragment));
   sizes->max_content = fragment->InlineOverflow();
@@ skipping 163 matching lines @@
       .SetBlockSize(layout_box_->logicalHeight())
       .SetDirection(layout_box_->styleRef().direction())
       .SetWritingMode(
           FromPlatformWritingMode(layout_box_->styleRef().getWritingMode()))
       .SetInlineOverflow(overflow.width())
       .SetBlockOverflow(overflow.height());
   return builder.ToFragment();
 }
 
 }  // namespace blink