Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2521303002: Rename IFWL_App to CFWL_App (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename IFWL_App to CFWL_App This class is not an interface but a concrete implementation. Rename to match. Committed: https://pdfium.googlesource.com/pdfium/+/1a7534a1a477323f7b8497e359f6af6e9bd54cd5

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -175 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fwl/core/cfwl_app.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + xfa/fwl/core/cfwl_app.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_barcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_notedriver.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_timer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D xfa/fwl/core/ifwl_app.h View 1 chunk +0 lines, -45 lines 0 comments Download
D xfa/fwl/core/ifwl_app.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_barcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_caret.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_comboboxproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_comboboxproxy.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_comboedit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_comboedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_combolist.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_combolist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_form.cpp View 7 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_formproxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_picturebox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 9 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/xfa_ffwidget.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-22 17:40:02 UTC) #2
Tom Sepez
LGTM based on spot inspection. Thanks.
4 years, 1 month ago (2016-11-22 18:07:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521303002/20001
4 years, 1 month ago (2016-11-22 23:42:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 23:56:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1a7534a1a477323f7b8497e359f6af6e9bd5...

Powered by Google App Engine
This is Rietveld 408576698