Rename IFWL_Timer and IFWL_TimerInfo

Rename IFWL_Timer and IFWL_TimerInfo

These twho files are not interfaces. Renamed to be CFWL to signify they are
concrete implementations.

Committed: https://pdfium.googlesource.com/pdfium/+/d64372989fcb4e5af66f437ad7b8be343cb1aa67

[dsinclair, 2016-11-22 16:39:48]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-22 16:39:49]

PTAL.

[dsinclair, 2016-11-22 16:48:00]

On 2016/11/22 16:39:49, dsinclair wrote:
> PTAL.

There is an error in here, ignore. I'll ping when ready.

[dsinclair, 2016-11-22 17:20:42]

Ok, PTAL.

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
File fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp (right):

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:15: namespace {
Tom, can you give this a look to make sure I didn't mess up converting to a
unique_ptr in here?

[Tom Sepez, 2016-11-22 18:29:55]

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
File fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp (right):

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:15: namespace {
On 2016/11/22 17:20:42, dsinclair wrote:
> Tom, can you give this a look to make sure I didn't mess up converting to a
> unique_ptr in here?

UPs are fine, some other comments.

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:30:
std::vector<std::unique_ptr<CFWL_TimerInfo>>*
where do we clean this up?
would std::set be more appropriate?  Then we can just
set.erase(FakeUniquePtr<>()) below.

even better, how about std::map of idEvent -> TimerInfo, given the lookup at
lines 77?  Then map.erase(blah->idevent) ??

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:71: for (auto& info : *s_TimerArray)
{
nit: const auto&

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:74: if (pInfo->idEvent != idEvent)
nit: not sure early continue helps here given the break later.

[Tom Sepez, 2016-11-22 18:30:53]

Anyways, I'd suggest splitting out the unique_ptr's to another CL, since we can
make a better cleanup with sets, etc and that's getting too large for this CL's
scope.

[dsinclair, 2016-11-22 22:05:20]

PTAL.

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
File fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp (right):

https://codereview.chromium.org/2526513002/diff/20001/fpdfsdk/fpdfxfa/cxfa_fw...
fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp:71: for (auto& info : *s_TimerArray)
{
On 2016/11/22 18:29:54, Tom Sepez wrote:
> nit: const auto&

Done.

[dsinclair, 2016-11-22 22:05:26]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:05:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 22:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 22:16:38]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-22 22:21:22]

lgtm

[Tom Sepez, 2016-11-22 22:30:46]

lgtm

[dsinclair, 2016-11-22 23:41:39]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479858099708830,
"parent_rev": "5048731cf0b1221a81e76d7f6e95f24159bb87e2", "commit_rev":
"d64372989fcb4e5af66f437ad7b8be343cb1aa67"}

[commit-bot: I haz the power, 2016-11-22 23:42:11]

Description was changed from

==========
Rename IFWL_Timer and IFWL_TimerInfo

These twho files are not interfaces. Renamed to be CFWL to signify they are
concrete implementations.
==========

to

==========
Rename IFWL_Timer and IFWL_TimerInfo

These twho files are not interfaces. Renamed to be CFWL to signify they are
concrete implementations.

Committed:
https://pdfium.googlesource.com/pdfium/+/d64372989fcb4e5af66f437ad7b8be343cb1...
==========

[commit-bot: I haz the power, 2016-11-22 23:42:12]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/d64372989fcb4e5af66f437ad7b8be343cb1...