Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2521063004: Replace ptr.reset with std::move in src/components (Closed)

Created:
4 years, 1 month ago by Yoonjae
Modified:
4 years, 1 month ago
Reviewers:
sdefresne, Yoonjae
CC:
chromium-reviews, vakh+watch_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ptr.reset with std::move in src/components BUG=644626 Committed: https://crrev.com/0d074f722de6e0687e1a572407380cc8fb6005fb Cr-Commit-Position: refs/heads/master@{#433843}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
Yoonjae
@sdefresne PTAL.
4 years, 1 month ago (2016-11-22 03:03:44 UTC) #2
sdefresne
lgtm Thank you for the cleanup!
4 years, 1 month ago (2016-11-22 11:41:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521063004/1
4 years, 1 month ago (2016-11-22 12:38:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 12:42:43 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 12:44:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d074f722de6e0687e1a572407380cc8fb6005fb
Cr-Commit-Position: refs/heads/master@{#433843}

Powered by Google App Engine
This is Rietveld 408576698