components/leveldb_proto/proto_database_impl.h - Issue 2521063004: Replace ptr.reset with std::move in src/components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/leveldb_proto/proto_database_impl.h

Issue 2521063004: Replace ptr.reset with std::move in src/components (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/leveldb_proto/proto_database_impl.h

diff --git a/components/leveldb_proto/proto_database_impl.h b/components/leveldb_proto/proto_database_impl.h

index 9997d382877a98ac3f7482c7495f20df0783e6bf..42c0dff677fcfa9d9c2f3f12ac78f13087f5f294 100644

--- a/components/leveldb_proto/proto_database_impl.h

+++ b/components/leveldb_proto/proto_database_impl.h

@@ -264,7 +264,7 @@ void ProtoDatabaseImpl<T>::InitWithDatabase(

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(!db_);

DCHECK(database);

- db_.reset(database.release());

+ db_ = std::move(database);

bool* success = new bool(false);

task_runner_->PostTaskAndReply(

FROM_HERE, base::Bind(InitFromTaskRunner, base::Unretained(db_.get()),