components/safe_browsing_db/v4_update_protocol_manager.cc - Issue 2521063004: Replace ptr.reset with std::move in src/components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.cc

Issue 2521063004: Replace ptr.reset with std::move in src/components (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_update_protocol_manager.cc

diff --git a/components/safe_browsing_db/v4_update_protocol_manager.cc b/components/safe_browsing_db/v4_update_protocol_manager.cc

index 47736aa73bf49eb98d9bb0632710a6a8a1d134ca..43c3c25f2623ea4393ca11032c98f4e4725d1826 100644

--- a/components/safe_browsing_db/v4_update_protocol_manager.cc

+++ b/components/safe_browsing_db/v4_update_protocol_manager.cc

@@ -290,7 +290,7 @@ void V4UpdateProtocolManager::IssueUpdateRequest() {

data_use_measurement::DataUseUserData::AttachToFetcher(

fetcher.get(), data_use_measurement::DataUseUserData::SAFE_BROWSING);

- request_.reset(fetcher.release());

+ request_ = std::move(fetcher);

request_->SetLoadFlags(net::LOAD_DISABLE_CACHE);

request_->SetRequestContext(request_context_getter_.get());