components/nacl/loader/nacl_ipc_adapter.cc - Issue 2521063004: Replace ptr.reset with std::move in src/components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_ipc_adapter.cc

Issue 2521063004: Replace ptr.reset with std::move in src/components (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_ipc_adapter.cc

diff --git a/components/nacl/loader/nacl_ipc_adapter.cc b/components/nacl/loader/nacl_ipc_adapter.cc

index 33f74f8c1a13aa98837266356018a7231b8a4dce..3465ee5a7322cb0954b4108ffcc1cb940ffc7aa8 100644

--- a/components/nacl/loader/nacl_ipc_adapter.cc

+++ b/components/nacl/loader/nacl_ipc_adapter.cc

@@ -773,7 +773,7 @@ bool NaClIPCAdapter::SendCompleteMessage(const char* buffer,

std::unique_ptr<IPC::Message> new_msg;

locked_data_.nacl_msg_scanner_.ScanUntrustedMessage(*msg, &new_msg);

if (new_msg)

- msg.reset(new_msg.release());

+ msg = std::move(new_msg);

// Actual send must be done on the I/O thread.

task_runner_->PostTask(FROM_HERE,