components/update_client/update_engine.cc - Issue 2521063004: Replace ptr.reset with std::move in src/components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/update_engine.cc

Issue 2521063004: Replace ptr.reset with std::move in src/components (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/update_client/update_engine.cc

diff --git a/components/update_client/update_engine.cc b/components/update_client/update_engine.cc

index c0bf0ae8c625f1e5f293dae729bae1df7866fce6..5e28be89460ce698b8087c6fedd6396434674088 100644

--- a/components/update_client/update_engine.cc

+++ b/components/update_client/update_engine.cc

@@ -100,7 +100,7 @@ void UpdateEngine::Update(

(*update_context->update_checker_factory)(config_, metadata_.get()),

config_->GetBrowserVersion(), config_->ExtraRequestParams()));

- update_context->current_action.reset(update_check_action.release());

+ update_context->current_action = std::move(update_check_action);

update_contexts_.insert(update_context.get());

update_context->current_action->Run(

« no previous file with comments | « components/update_client/action_update.cc ('k') | no next file » | no next file with comments »