Remove RELEASE_NOTREACHED().

Remove RELEASE_NOTREACHED().

It was introduced to replace RELEASE_ASSERT_NOT_REACHED() inherited from WebKit.
However, it's not so popular and using LOG(FATAL) directly is enough.

BUG=596760
Committed: https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88
Cr-Commit-Position: refs/heads/master@{#433478}

[tkent, 2016-11-21 01:47:51]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 01:48:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 03:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 03:26:23]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-21 03:30:58]

tkent@chromium.org changed reviewers:
+ yutak@chromium.org

[tkent, 2016-11-21 03:30:58]

yutak@, would you review this please?

[Yuta Kitamura, 2016-11-21 05:39:41]

lgtm

[tkent, 2016-11-21 05:43:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-21 05:43:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 05:47:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479707013280000, "parent_rev":
["f083dad99321b2fd940c944e4dff2ce99496d3b2", null], "commit_rev":
["4794a5a45f37029562ad6f4a14e8496b4d663e45", null]}

[commit-bot: I haz the power, 2016-11-21 05:47:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 05:49:53]

Description was changed from

==========
Remove RELEASE_NOTREACHED().

It was introduced to replace RELEASE_ASSERT_NOT_REACHED() inherited from WebKit.
However, it's not so popular and using LOG(FATAL) directly is enough.

BUG=596760
==========

to

==========
Remove RELEASE_NOTREACHED().

It was introduced to replace RELEASE_ASSERT_NOT_REACHED() inherited from WebKit.
However, it's not so popular and using LOG(FATAL) directly is enough.

BUG=596760

Committed: https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88
Cr-Commit-Position: refs/heads/master@{#433478}
==========

[commit-bot: I haz the power, 2016-11-21 05:49:54]

Patchset 1 (id:??) landed as
https://crrev.com/618a03472d837aa934ab9c9a8f2b326f031d0e88
Cr-Commit-Position: refs/heads/master@{#433478}

[esprehn, 2016-11-21 20:24:02]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-11-21 20:24:02]

I think this probably needs a PSA, it's not at all clear that LOG(FATAL) results
in a CRASH(), generally LOG is passive.

[Yuta Kitamura, 2016-11-22 01:24:10]

On 2016/11/21 20:24:02, esprehn wrote:
> I think this probably needs a PSA, it's not at all clear that LOG(FATAL)
results
> in a CRASH(), generally LOG is passive.

Just to give another data point, I actually knew that. I thought
that was common.

[tkent, 2016-11-22 02:25:23]

On 2016/11/22 at 01:24:10, yutak wrote:
> On 2016/11/21 20:24:02, esprehn wrote:
> > I think this probably needs a PSA, it's not at all clear that LOG(FATAL)
results
> > in a CRASH(), generally LOG is passive.
> 
> Just to give another data point, I actually knew that. I thought
> that was common.

Blink-only contributors might be unfamiliar with it.
I'll send a update of ASSERT deprecation, and mention this change.