Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2518933002: Remove RELEASE_NOTREACHED(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
index 3d13295c301bf1f1ffe55080cfade9cc5ce3ed76..b6f4c38a4ae1f3e604b4756cd84ccd68be1bc48b 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
@@ -40,9 +40,9 @@ DOMWindow::~DOMWindow() {}
v8::Local<v8::Object> DOMWindow::wrap(v8::Isolate*,
v8::Local<v8::Object> creationContext) {
- // DOMWindow must never be wrapped with wrap method. The wrappers must be
- // created at WindowProxy::createContext() and setupWindowPrototypeChain().
- RELEASE_NOTREACHED();
+ LOG(FATAL) << "DOMWindow must never be wrapped with wrap method. The "
+ "wrappers must be created at WindowProxy::createContext() and "
+ "setupWindowPrototypeChain().";
return v8::Local<v8::Object>();
}
@@ -50,7 +50,9 @@ v8::Local<v8::Object> DOMWindow::associateWithWrapper(
v8::Isolate*,
const WrapperTypeInfo*,
v8::Local<v8::Object> wrapper) {
- RELEASE_NOTREACHED(); // same as wrap method
+ LOG(FATAL) << "DOMWindow must never be wrapped with wrap method. The "
+ "wrappers must be created at WindowProxy::createContext() and "
+ "setupWindowPrototypeChain().";
return v8::Local<v8::Object>();
}

Powered by Google App Engine
This is Rietveld 408576698