Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp

Issue 2518933002: Remove RELEASE_NOTREACHED(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
index d7ca5b48fec30352996d5656c8379caf02b6ae2d..bb7164c465ff3f6d87b1ab81e7cac4e772f619ae 100644
--- a/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
@@ -35,9 +35,9 @@ void WorkletGlobalScope::dispose() {
v8::Local<v8::Object> WorkletGlobalScope::wrap(
v8::Isolate*,
v8::Local<v8::Object> creationContext) {
- // WorkletGlobalScope must never be wrapped with wrap method. The global
- // object of ECMAScript environment is used as the wrapper.
- RELEASE_NOTREACHED();
+ LOG(FATAL) << "WorkletGlobalScope must never be wrapped with wrap method. "
+ "The global object of ECMAScript environment is used as the "
+ "wrapper.";
return v8::Local<v8::Object>();
}
@@ -45,7 +45,9 @@ v8::Local<v8::Object> WorkletGlobalScope::associateWithWrapper(
v8::Isolate*,
const WrapperTypeInfo*,
v8::Local<v8::Object> wrapper) {
- RELEASE_NOTREACHED(); // Same as wrap method.
+ LOG(FATAL) << "WorkletGlobalScope must never be wrapped with wrap method. "
+ "The global object of ECMAScript environment is used as the "
+ "wrapper.";
return v8::Local<v8::Object>();
}
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698