Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2518933002: Remove RELEASE_NOTREACHED(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
index dfa97feac7f92d19183ef7ea19ff1b26e7f975b1..dbeaca533a8f29a5b2d5d28e1ac28a69ae0dee98 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
@@ -240,9 +240,9 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls,
v8::Local<v8::Object> WorkerGlobalScope::wrap(
v8::Isolate*,
v8::Local<v8::Object> creationContext) {
- // WorkerGlobalScope must never be wrapped with wrap method. The global
- // object of ECMAScript environment is used as the wrapper.
- RELEASE_NOTREACHED();
+ LOG(FATAL) << "WorkerGlobalScope must never be wrapped with wrap method. "
+ "The global object of ECMAScript environment is used as the "
+ "wrapper.";
return v8::Local<v8::Object>();
}
@@ -250,7 +250,9 @@ v8::Local<v8::Object> WorkerGlobalScope::associateWithWrapper(
v8::Isolate*,
const WrapperTypeInfo*,
v8::Local<v8::Object> wrapper) {
- RELEASE_NOTREACHED(); // same as wrap method
+ LOG(FATAL) << "WorkerGlobalScope must never be wrapped with wrap method. "
+ "The global object of ECMAScript environment is used as the "
+ "wrapper.";
return v8::Local<v8::Object>();
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.cpp ('k') | third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698