Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2518933002: Remove RELEASE_NOTREACHED(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
index e4a36783edf4b694a28695ee039b1d31724996bb..c62ef76229be9d2a765098793714c03f648b896c 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
@@ -380,7 +380,7 @@ void FetchManager::Loader::didReceiveResponse(
tainting = FetchRequestData::CORSTainting;
break;
case WebURLRequest::FetchRequestModeNavigate:
- RELEASE_NOTREACHED();
+ LOG(FATAL);
break;
}
}
@@ -400,10 +400,9 @@ void FetchManager::Loader::didReceiveResponse(
// ServiceWorker can't respond to the request from fetch() with an
// opaque redirect response.
case WebServiceWorkerResponseTypeError:
- // When ServiceWorker respond to the request from fetch() with an
- // error response, FetchManager::Loader::didFail() must be called
- // instead.
- RELEASE_NOTREACHED();
+ LOG(FATAL) << "When ServiceWorker respond to the request from fetch() "
+ "with an error response, FetchManager::Loader::didFail() "
+ "must be called instead.";
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698