Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2518253002: Move Partition Allocator into Chromium base. (Closed)

Created:
4 years ago by palmer
Modified:
4 years ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, Mikhail, oilpan-reviews, tzik, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Partition Allocator into Chromium base. This will enable more parts of Chromium to use PA, and will make it easier for things outside of Chromium (e.g. PDFium) to use PA. This change is intended to be merely a move, and should not have significant performance impact. This moves only the core of PA; higher API layers that Blink uses to call into PA remain in Blink. BUG=632441 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/a988c5022f9bc4fb75ac0b86dda8005ee57ff357 Cr-Commit-Position: refs/heads/master@{#438471}

Patch Set 1 #

Total comments: 42

Patch Set 2 : Respond to comments. #

Total comments: 27

Patch Set 3 : Respond to more of Primiano's comments; move PartitionAllocator.* back to wtf; some build fixes #

Total comments: 10

Patch Set 4 : Rebase; address (?) some Windows compile failures. #

Patch Set 5 : Remove PRETTY_FUNCTION, and fix (?) ByteSwap for uintptr_t on macOS/iOS. #

Total comments: 7

Patch Set 6 : Add test ByteOrderTest.ByteSwapUintPtrT, and explicitly fail to build for ancient/future computers #

Patch Set 7 : Oops, use the right ByteSwapUintPtrT for the unit test. #

Patch Set 8 : Fix macOS/iOS unit tests build; fix terrible logic reversal bug. #

Patch Set 9 : EXPECT_DEATH is not supported on iOS; #ifdef it out. #

Total comments: 3

Patch Set 10 : Handle the iOS EXPECT_DEATH problem in a better way. #

Patch Set 11 : Resolve TODOs: Re-enable getAllocPageErrorCode. #

Patch Set 12 : Rebase and resolve conflict. #

Total comments: 17

Patch Set 13 : Respond to comments. #

Total comments: 3

Patch Set 14 : Add static_asserts to ensure that ByteSwapUintPtrT is correct, and just use CHECK. #

Total comments: 1

Patch Set 15 : Handle the case when defined(ARCH_CPU_64_BITS) but sizeof(uintptr_t) is 4. #

Patch Set 16 : [mangled patchset name due to bug in `git cl upload`] #

Patch Set 17 : Handle the case when defined(ARCH_CPU_64_BITS) and sizeof(uintptr_t) == 4. #

Patch Set 18 : Disable PartitionAllocTest.RepeatedReturn* on Android (they can't be reliable there). #

Patch Set 19 : PartitionAllocTest.CLZWorks → BitsTest.CLZWorks. Remove the PA copy. #

Patch Set 20 : Move OOM_CRASH into its own, more specific header. Fixes Windows build. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+653 lines, -6006 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +12 lines, -0 lines 0 comments Download
A base/allocator/oom.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +26 lines, -0 lines 1 comment Download
A base/allocator/partition_allocator/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
A + base/allocator/partition_allocator/PartitionAlloc.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A base/allocator/partition_allocator/address_space_randomization.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + base/allocator/partition_allocator/address_space_randomization.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +24 lines, -24 lines 0 comments Download
A + base/allocator/partition_allocator/page_allocator.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +33 lines, -62 lines 0 comments Download
A + base/allocator/partition_allocator/page_allocator.cc View 1 2 3 4 5 6 7 8 9 10 10 chunks +66 lines, -92 lines 0 comments Download
A + base/allocator/partition_allocator/partition_alloc.h View 1 2 3 4 13 33 chunks +104 lines, -157 lines 0 comments Download
A + base/allocator/partition_allocator/partition_alloc.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 60 chunks +165 lines, -192 lines 0 comments Download
A + base/allocator/partition_allocator/partition_alloc_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 22 chunks +57 lines, -68 lines 0 comments Download
M base/logging.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -12 lines 0 comments Download
M base/logging.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -1 line 0 comments Download
M base/sys_byteorder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +16 lines, -0 lines 0 comments Download
M base/sys_byteorder_unittest.cc View 1 2 3 4 5 6 2 chunks +20 lines, -0 lines 0 comments Download
M docs/memory-infra/README.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 2 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Allocator.h View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/BitVector.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Compiler.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashCountedSet.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashMap.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/allocator/AddressSpaceRandomization.h View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/AddressSpaceRandomization.cpp View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PageAllocator.h View 1 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp View 1 chunk +0 lines, -298 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h View 1 chunk +0 lines, -957 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp View 1 chunk +0 lines, -1492 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAlloc.md View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAllocTest.cpp View 1 chunk +0 lines, -2118 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +13 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/wtf/allocator/PartitionAllocator.cpp View 1 2 1 chunk +4 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/Partitions.h View 1 2 3 4 5 6 7 8 9 10 5 chunks +37 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/Partitions.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 106 (51 generated)
palmer
Although this CL is big, it should be just a move — there should be ...
4 years ago (2016-11-22 03:04:57 UTC) #2
haraken
This looks like a right way forward. https://codereview.chromium.org/2518253002/diff/1/base/allocator/partition_allocator/partitions.h File base/allocator/partition_allocator/partitions.h (right): https://codereview.chromium.org/2518253002/diff/1/base/allocator/partition_allocator/partitions.h#newcode25 base/allocator/partition_allocator/partitions.h:25: ALWAYS_INLINE static ...
4 years ago (2016-11-22 03:55:11 UTC) #3
Primiano Tucci (use gerrit)
Did a first pass. Many wow, such thanks for the work. As more general comments: ...
4 years ago (2016-11-22 14:28:33 UTC) #4
haraken
On 2016/11/22 14:28:33, Primiano Tucci wrote: > Did a first pass. Many wow, such thanks ...
4 years ago (2016-11-22 14:42:15 UTC) #5
palmer
https://codereview.chromium.org/2518253002/diff/1/base/allocator/partition_allocator/PartitionAlloc.md File base/allocator/partition_allocator/PartitionAlloc.md (right): https://codereview.chromium.org/2518253002/diff/1/base/allocator/partition_allocator/PartitionAlloc.md#newcode1 base/allocator/partition_allocator/PartitionAlloc.md:1: # PartitionAlloc Design > since you are moving this, ...
4 years ago (2016-11-24 01:05:57 UTC) #6
Primiano Tucci (use gerrit)
second batch of comments, sorry for the dual pass but just takes a bit of ...
4 years ago (2016-11-28 12:06:50 UTC) #7
palmer
Thank you, Primiano! A new patchset with these fixes and more coming up soon. https://codereview.chromium.org/2518253002/diff/20001/base/BUILD.gn ...
4 years ago (2016-12-01 00:48:24 UTC) #8
gab
Reviewing base/ in lieu of danakj (per her request to alleviate review load). https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn File ...
4 years ago (2016-12-05 18:51:48 UTC) #15
palmer
https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn#newcode1225 base/BUILD.gn:1225: sources += [ > Add these to all sources ...
4 years ago (2016-12-06 00:58:25 UTC) #20
gab
https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn#newcode1225 base/BUILD.gn:1225: sources += [ On 2016/12/06 00:58:25, palmer wrote: > ...
4 years ago (2016-12-06 15:43:21 UTC) #21
gab
https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2518253002/diff/40001/base/BUILD.gn#newcode1225 base/BUILD.gn:1225: sources += [ On 2016/12/06 15:43:21, gab wrote: > ...
4 years ago (2016-12-06 15:55:06 UTC) #22
palmer
New patchset coming up. https://codereview.chromium.org/2518253002/diff/80001/base/logging.h File base/logging.h (right): https://codereview.chromium.org/2518253002/diff/80001/base/logging.h#newcode24 base/logging.h:24: #include <windows.h> On 2016/12/06 at ...
4 years ago (2016-12-06 21:47:41 UTC) #23
gab
https://codereview.chromium.org/2518253002/diff/80001/base/logging.h File base/logging.h (right): https://codereview.chromium.org/2518253002/diff/80001/base/logging.h#newcode24 base/logging.h:24: #include <windows.h> On 2016/12/06 21:47:41, palmer wrote: > On ...
4 years ago (2016-12-07 15:34:57 UTC) #36
palmer
> > OOM_CRASH (added in this CL) needs it for ::RaiseException. > > This CL's ...
4 years ago (2016-12-07 19:00:03 UTC) #37
palmer
https://codereview.chromium.org/2518253002/diff/160001/base/allocator/partition_allocator/partition_alloc_unittest.cc File base/allocator/partition_allocator/partition_alloc_unittest.cc (right): https://codereview.chromium.org/2518253002/diff/160001/base/allocator/partition_allocator/partition_alloc_unittest.cc#newcode1327 base/allocator/partition_allocator/partition_alloc_unittest.cc:1327: #if !defined(OS_ANDROID) && !defined(OS_IOS) > // Death tests misbehave ...
4 years ago (2016-12-07 19:00:13 UTC) #38
gab
base/ (% base/allocator) lgtm
4 years ago (2016-12-07 20:39:23 UTC) #39
gab
https://codereview.chromium.org/2518253002/diff/160001/base/allocator/partition_allocator/partition_alloc_unittest.cc File base/allocator/partition_allocator/partition_alloc_unittest.cc (right): https://codereview.chromium.org/2518253002/diff/160001/base/allocator/partition_allocator/partition_alloc_unittest.cc#newcode1327 base/allocator/partition_allocator/partition_alloc_unittest.cc:1327: #if !defined(OS_ANDROID) && !defined(OS_IOS) On 2016/12/07 19:00:13, palmer wrote: ...
4 years ago (2016-12-07 20:40:48 UTC) #40
palmer
> base/ (% base/allocator) lgtm haraken, primiano: LGTY?
4 years ago (2016-12-07 20:44:45 UTC) #41
palmer
> Actually, I don't see this change, missing upload? Right. Uploading it now.
4 years ago (2016-12-07 20:46:38 UTC) #42
haraken
Mostly LG. This looks amazing! https://codereview.chromium.org/2518253002/diff/220001/base/allocator/OWNERS File base/allocator/OWNERS (right): https://codereview.chromium.org/2518253002/diff/220001/base/allocator/OWNERS#newcode1 base/allocator/OWNERS:1: palmer@chromium.org Would you add ...
4 years ago (2016-12-08 08:43:56 UTC) #48
Primiano Tucci (use gerrit)
//base/allocator LGTM . The only thing missing right now is naming, which is inconsistent with ...
4 years ago (2016-12-08 17:14:06 UTC) #49
gab
https://codereview.chromium.org/2518253002/diff/220001/base/logging.h File base/logging.h (right): https://codereview.chromium.org/2518253002/diff/220001/base/logging.h#newcode23 base/logging.h:23: #if defined(OS_WIN) On 2016/12/08 17:14:05, Primiano Tucci wrote: > ...
4 years ago (2016-12-08 18:19:10 UTC) #50
palmer
https://codereview.chromium.org/2518253002/diff/220001/base/allocator/OWNERS File base/allocator/OWNERS (right): https://codereview.chromium.org/2518253002/diff/220001/base/allocator/OWNERS#newcode1 base/allocator/OWNERS:1: palmer@chromium.org On 2016/12/08 at 17:14:05, Primiano Tucci wrote: > ...
4 years ago (2016-12-08 22:29:58 UTC) #51
haraken
LGTM
4 years ago (2016-12-09 00:17:53 UTC) #56
haraken
Maybe you can send a PSA to blink-dev@. This is a change people have wished ...
4 years ago (2016-12-09 00:18:23 UTC) #57
danakj
https://codereview.chromium.org/2518253002/diff/220001/base/allocator/partition_allocator/partition_alloc.h File base/allocator/partition_allocator/partition_alloc.h (right): https://codereview.chromium.org/2518253002/diff/220001/base/allocator/partition_allocator/partition_alloc.h#newcode701 base/allocator/partition_allocator/partition_alloc.h:701: CHECK(result); On 2016/12/08 22:29:58, palmer wrote: > > > ...
4 years ago (2016-12-09 00:20:15 UTC) #58
palmer
> > So, Done. I copied and pasted the RELEASE_ASSERT implementation from > > wtf/Assertions.h ...
4 years ago (2016-12-09 00:46:46 UTC) #59
danakj
On Thu, Dec 8, 2016 at 4:46 PM, <palmer@chromium.org> wrote: > > > So, Done. ...
4 years ago (2016-12-09 04:48:09 UTC) #60
danakj
Anyhow, I'm going to off codereview for a few days. I looked over the base/ ...
4 years ago (2016-12-09 04:52:05 UTC) #61
danakj
On Thu, Dec 8, 2016 at 4:46 PM, <palmer@chromium.org> wrote: > > > So, Done. ...
4 years ago (2016-12-09 04:54:30 UTC) #62
haraken
Also please add more explanation to the CL description.
4 years ago (2016-12-09 11:39:29 UTC) #63
palmer
> Also please add more explanation to the CL description. Done.
4 years ago (2016-12-09 20:26:59 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518253002/260001
4 years ago (2016-12-09 20:29:18 UTC) #69
gab
https://codereview.chromium.org/2518253002/diff/260001/base/sys_byteorder.h File base/sys_byteorder.h (right): https://codereview.chromium.org/2518253002/diff/260001/base/sys_byteorder.h#newcode56 base/sys_byteorder.h:56: "uintptr_t not the same as uinti32_t"); nit: typo s/uinti32_t/uint32_t/
4 years ago (2016-12-09 21:01:56 UTC) #70
palmer
> https://codereview.chromium.org/2518253002/diff/260001/base/sys_byteorder.h#newcode56 > base/sys_byteorder.h:56: "uintptr_t not the same as uinti32_t"); > nit: typo s/uinti32_t/uint32_t/ Fixed; ...
4 years ago (2016-12-13 03:02:02 UTC) #76
Primiano Tucci (use gerrit)
On 2016/12/13 03:02:02, palmer wrote: > Regarding the android_n5x_swarming_rel failures: I am finding that > ...
4 years ago (2016-12-13 10:16:54 UTC) #77
danakj
Nexus5x bots are also building arm64 fwiw, might be related. On Mon, Dec 12, 2016 ...
4 years ago (2016-12-13 14:06:06 UTC) #78
danakj
Nexus5x bots are also building arm64 fwiw, might be related. On Mon, Dec 12, 2016 ...
4 years ago (2016-12-13 14:06:06 UTC) #79
palmer
> Yes please disable this test (and any other that has some similar memory saturation ...
4 years ago (2016-12-13 19:12:11 UTC) #80
palmer
> Nexus5x bots are also building arm64 fwiw, might be related. Right. I experienced the ...
4 years ago (2016-12-13 19:13:02 UTC) #81
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518253002/360001
4 years ago (2016-12-13 19:13:47 UTC) #84
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/313959)
4 years ago (2016-12-13 20:08:30 UTC) #86
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518253002/380001
4 years ago (2016-12-13 22:38:53 UTC) #89
danakj
https://codereview.chromium.org/2518253002/diff/380001/base/allocator/oom.h File base/allocator/oom.h (right): https://codereview.chromium.org/2518253002/diff/380001/base/allocator/oom.h#newcode19 base/allocator/oom.h:19: ::RaiseException(0xE0000008, EXCEPTION_NONCONTINUABLE, 0, nullptr); \ This is in base ...
4 years ago (2016-12-13 23:56:13 UTC) #90
palmer
> File base/allocator/oom.h (right): > > https://codereview.chromium.org/2518253002/diff/380001/base/allocator/oom.h#newcode19 > base/allocator/oom.h:19: ::RaiseException(0xE0000008, EXCEPTION_NONCONTINUABLE, 0, nullptr); \ > ...
4 years ago (2016-12-14 00:10:05 UTC) #91
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/349329)
4 years ago (2016-12-14 01:41:24 UTC) #93
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518253002/380001
4 years ago (2016-12-14 05:53:55 UTC) #95
commit-bot: I haz the power
Committed patchset #20 (id:380001)
4 years ago (2016-12-14 09:41:11 UTC) #98
commit-bot: I haz the power
Patchset 20 (id:??) landed as https://crrev.com/a988c5022f9bc4fb75ac0b86dda8005ee57ff357 Cr-Commit-Position: refs/heads/master@{#438471}
4 years ago (2016-12-14 09:42:42 UTC) #100
danakj
On Tue, Dec 13, 2016 at 4:10 PM, <palmer@chromium.org> wrote: > > File base/allocator/oom.h (right): ...
4 years ago (2016-12-14 16:08:41 UTC) #101
danakj
On Tue, Dec 13, 2016 at 4:10 PM, <palmer@chromium.org> wrote: > > File base/allocator/oom.h (right): ...
4 years ago (2016-12-14 16:13:49 UTC) #102
Primiano Tucci (use gerrit)
Ah I forgot to mention. Now that this cl is landed your name will be ...
4 years ago (2016-12-14 23:46:46 UTC) #103
haraken
On 2016/12/14 23:46:46, Primiano Tucci wrote: > Ah I forgot to mention. Now that this ...
4 years ago (2016-12-15 00:20:35 UTC) #104
haraken
On 2016/12/15 00:20:35, haraken wrote: > On 2016/12/14 23:46:46, Primiano Tucci wrote: > > Ah ...
4 years ago (2016-12-15 00:21:52 UTC) #105
palmer
4 years ago (2016-12-15 00:25:10 UTC) #106
Message was sent while issue was closed.
> What would the next step?
> 
> - Create a Skia partition and move Skia things there
> - Create a V8 partition and move V8 things there
> - Create a CC partition and move CC things there
> 
> ?

I think I'm going to try PDFium next, it's a soft target and I hear that an open
source contributor has already tried it, even. But, let's chat further on the
platform-architecture-dev@ list.

Powered by Google App Engine
This is Rietveld 408576698