Move Partition Allocator into Chromium base.

base/compiler_specific.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_COMPILER_SPECIFIC_H_
 #define BASE_COMPILER_SPECIFIC_H_
 
 #include "build/build_config.h"
 
 #if defined(COMPILER_MSVC)
@@ skipping 212 matching lines @@
 #endif  // !defined(LIKELY)
 
 // Compiler feature-detection.
 // clang.llvm.org/docs/LanguageExtensions.html#has-feature-and-has-extension
 #if defined(__has_feature)
 #define HAS_FEATURE(FEATURE) __has_feature(FEATURE)
 #else
 #define HAS_FEATURE(FEATURE) 0
 #endif
 
+#if defined(COMPILER_GCC)

[gab, 2016/12/05 18:51:48]

The last comment below makes this not compiler specific.

+#define PRETTY_FUNCTION __PRETTY_FUNCTION__
+#elif defined(COMPILER_MSVC)
+#define PRETTY_FUNCTION __FUNCSIG__
+#else
+#define PRETTY_FUNCTION __func__
+#endif
+
+// Returns a string that contains the type name of |T| as a substring.
+template <typename T>
+inline const char* GetStringWithTypeName() {

[gab, 2016/12/05 18:51:48]

Given this is only used in base/allocator it should live in it (ref.
base/OWNERS).

[palmer, 2016/12/06 00:58:25]

Turns out I can leave it in WTF (since I moved
wtf/allocator/PartitionAllocator.h back into WTF). So we can get rid of this
entirely.

+  return PRETTY_FUNCTION;

[gab, 2016/12/05 18:51:48]

I think typeid(T).name() would be cleaner here?

http://en.cppreference.com/w/cpp/language/typeid

Though type_info::name is implementation defined
(http://en.cppreference.com/w/cpp/types/type_info), so it might be mangled,
depends how hard this needs to contain "T" perfectly as a substring?

[palmer, 2016/12/06 00:58:25]

It would be, but the compiler says: "error: cannot use typeid with -fno-rtti".
Alas!

[gab, 2016/12/06 15:43:21]

Interesting, I couldn't find where this flag is set in GN but I found another
callsite that would like it not to be:
https://cs.chromium.org/chromium/src/gin/function_template.h?rcl=0&l=142

Since your method is only intended to be used in Debug builds maybe it'd make
sense to enable RTTI in Debug builds?

+}
+
 #endif  // BASE_COMPILER_SPECIFIC_H_