Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org,yolandyan@chromium.org
BUG=666193, 667337, 462676, 665157, 665478, 667437
Committed: https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d
Cr-Commit-Position: refs/heads/master@{#433681}

[F, 2016-11-21 16:34:08]

Created Reland of Add GN build rules to allow java_assertion_enabler to enable
Java asserts.

[F, 2016-11-21 17:04:07]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Will update when fixed

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666193
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Will update when fixed

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478
==========

[F, 2016-11-21 17:05:19]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Will update when fixed

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478
==========

[F, 2016-11-21 17:07:32]

Patchset #1 (id:1) has been deleted

[F, 2016-11-21 17:08:06]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 17:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 18:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 18:51:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[F, 2016-11-21 19:45:54]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478,667437
==========

[F, 2016-11-21 19:48:47]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2016-11-21 19:48:57]

The CQ bit was unchecked by zpeng@chromium.org

[F, 2016-11-21 19:50:39]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 19:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-11-21 19:52:27]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2506263003/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to
enable Java asserts. (patchset #2 id:140001 of
https://codereview.chromium.org/2506013004/ )
> 
> Reason for revert:
> This CL cause WebView to crash
> 
> BUG=666193
> 
> Original issue's description:
> > Reland of Add GN build rules to allow java_assertion_enabler to
enable Java asserts.
> >
> > Reverted in:
> > https://codereview.chromium.org/2507153002/
> >
> > Reason for reland:
> > Now explicitly lists default toolchain
> >
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> >
> >
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> > BUG=462676,665157,665478
> >
> > Committed:
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
> > Cr-Commit-Position: refs/heads/master@{#432607}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478
> 
> Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca
> Cr-Commit-Position: refs/heads/master@{#432789}

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Not skipping CQ checks because original CL landed more than 1 days
ago.
BUG=666193,667337,462676,665157,665478,667437
==========

to

==========
Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=666193,667337,462676,665157,665478,667437
==========

[agrieve, 2016-11-21 19:53:25]

On 2016/11/21 16:34:08, F wrote:
> Created Reland of Add GN build rules to allow java_assertion_enabler to enable
> Java asserts.

lgtm

[F, 2016-11-21 19:59:03]

The CQ bit was unchecked by zpeng@chromium.org

[F, 2016-11-21 19:59:47]

The CQ bit was checked by zpeng@chromium.org

[F, 2016-11-21 19:59:48]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2517203002/#ps250001
(title: "format nit")

[commit-bot: I haz the power, 2016-11-21 20:00:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 23:05:06]

CQ is committing da patch.

Bot data: {"patchset_id": 250001, "attempt_start_ts": 1479758387674270,
"parent_rev": "2efb21b6e77638a76a9bf9ccaeb9a3658a9dfc2c", "commit_rev":
"a4afbafa58f03c24fc85a6662142df70d88ecaf1"}

[commit-bot: I haz the power, 2016-11-21 23:05:33]

Description was changed from

==========
Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=666193,667337,462676,665157,665478,667437
==========

to

==========
Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=666193,667337,462676,665157,665478,667437
==========

[commit-bot: I haz the power, 2016-11-21 23:05:34]

Committed patchset #3 (id:250001)

[commit-bot: I haz the power, 2016-11-21 23:08:22]

Description was changed from

==========
Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=666193,667337,462676,665157,665478,667437
==========

to

==========
Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted by:
https://codereview.chromium.org/2506263003/

Reason for reland:
Fixed failing tests.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=666193,667337,462676,665157,665478,667437

Committed: https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d
Cr-Commit-Position: refs/heads/master@{#433681}
==========

[commit-bot: I haz the power, 2016-11-21 23:08:24]

Patchset 3 (id:??) landed as
https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d
Cr-Commit-Position: refs/heads/master@{#433681}

[boliu, 2016-11-23 16:50:39]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2016-11-23 16:50:39]

this CL should *not* have been tbr-ed.

https://codereview.chromium.org/2517203002/diff/250001/android_webview/tools/...
File
android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java
(right):

https://codereview.chromium.org/2517203002/diff/250001/android_webview/tools/...
android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java:21:
private static final long TIMEOUT = scaleTimeout(4000);
what does this have to do with asserts?

[boliu, 2016-11-23 17:20:23]

https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
(right):

https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java:252:
// assert mObservers.isEmpty();
also is this being fixed?

[agrieve, 2016-11-23 17:55:39]

Sorry, I think tbr was appropriate since the change was 99% the same as last
time, and I reviewed the different parts. 

The timeout was causing the test to fail for zpeng@ locally when running that
test. Admittedly, bumping that should have been a separate change.

https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
(right):

https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java:252:
// assert mObservers.isEmpty();
On 2016/11/23 17:20:22, boliu_back_dec wrote:
> also is this being fixed?

Looks like there's action on the bug.

[boliu, 2016-11-23 18:03:36]

On 2016/11/23 17:55:39, agrieve wrote:
> Sorry, I think tbr was appropriate since the change was 99% the same as last
> time, and I reviewed the different parts. 

Additional changes still needs to be reviewed by owners

> 
> The timeout was causing the test to fail for zpeng@ locally when running that
> test. Admittedly, bumping that should have been a separate change.
> 
>
https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
> File
>
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
> (right):
> 
>
https://codereview.chromium.org/2517203002/diff/250001/content/public/android...
>
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java:252:
> // assert mObservers.isEmpty();
> On 2016/11/23 17:20:22, boliu_back_dec wrote:
> > also is this being fixed?
> 
> Looks like there's action on the bug.