Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2507153002: Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (Closed)

Created:
4 years, 1 month ago by F
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #4 id:60001 of https://codereview.chromium.org/2497043002/ ) Reason for revert: Broke arm64 builder: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/42836 Original issue's description: > Add GN build rules to allow java_assertion_enabler to enable Java asserts. > > Also modify java_assertion_enabler to resolve cycle dependency issue > and empty jar issue. > > BUG=462676, 665157, 665478 > > Committed: https://crrev.com/5d3328f05a88be232e11d2ce34bffa64ca2362a5 > Cr-Commit-Position: refs/heads/master@{#432521} TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462676, 665157, 665478 Committed: https://crrev.com/a877ad3e0cc023956bd38fcf9018b028ba35f15e Cr-Commit-Position: refs/heads/master@{#432564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -142 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M build/android/java_assertion_enabler/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java View 3 chunks +28 lines, -55 lines 0 comments Download
M build/config/android/internal_rules.gni View 8 chunks +37 lines, -80 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 chunk +1 line, -2 lines 0 comments Download
M media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/ow2_asm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
F
Created Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts.
4 years, 1 month ago (2016-11-16 18:22:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507153002/1
4 years, 1 month ago (2016-11-16 18:23:10 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-16 18:23:12 UTC) #5
agrieve
On 2016/11/16 18:23:12, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 1 month ago (2016-11-16 18:24:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507153002/1
4 years, 1 month ago (2016-11-16 18:25:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 18:27:12 UTC) #10
F
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2506013004/ by zpeng@chromium.org. ...
4 years, 1 month ago (2016-11-16 18:28:43 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 18:52:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a877ad3e0cc023956bd38fcf9018b028ba35f15e
Cr-Commit-Position: refs/heads/master@{#432564}

Powered by Google App Engine
This is Rietveld 408576698