content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java - Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (Closed)

Patch Set: format nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java ('K') | « build/config/android/internal_rules.gni ('k') | media/base/android/java/src/org/chromium/media/MediaCodecBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

index 8e1b89ee04ee64fdea3fe8687d1557c5c56ce2db..a2cfb6f61e06284c1e257da99f073d3cceed1518 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

@@ -248,7 +248,8 @@ class WebContentsObserverProxy extends WebContentsObserver {

}

// All observer destroy() implementations should result in their removal

// from the proxy.

- assert mObservers.isEmpty();

+ // TODO(crbug.com/667437)

+ // assert mObservers.isEmpty();

boliu 2016/11/23 17:20:22 also is this being fixed?

agrieve 2016/11/23 17:55:39 Looks like there's action on the bug.

mObservers.clear();

if (mNativeWebContentsObserverProxy != 0) {