android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java - Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (Closed)

Patch Set: format nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « BUILD.gn ('k') | android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java » ('j') | android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

index 5681f9d560bdb4ed3bdb43b1ee89d8f95204ebd7..687eaa1ed6cd1bb6ce7429686c1119ee5e406bb4 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

@@ -443,7 +443,9 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {

// Only on UI thread.

AwBrowserContext getBrowserContextOnUiThread() {

- assert mStarted;

+ // TODO(crbug.com/667337)

+ // assert mStarted;

if (BuildConfig.DCHECK_IS_ON && !ThreadUtils.runningOnUiThread()) {

throw new RuntimeException(

"getBrowserContextOnUiThread called on " + Thread.currentThread());