media/base/android/java/src/org/chromium/media/MediaCodecBridge.java - Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

Issue 2517203002: Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (Closed)

Patch Set: format nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java ('K') | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java ('k') | media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

diff --git a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

index d04884e9d446a9b911566e5826b460a3a82574fe..4b3dce0885ed05d961e6b8d1362f57f774e5fccc 100644

--- a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

+++ b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

@@ -456,7 +456,8 @@ class MediaCodecBridge {

status = MEDIA_CODEC_OK;

index = indexOrStatus;

} else if (indexOrStatus == MediaCodec.INFO_OUTPUT_BUFFERS_CHANGED) {

- assert Build.VERSION.SDK_INT <= Build.VERSION_CODES.KITKAT;

+ // TODO(crbug.com/665478)

+ // assert Build.VERSION.SDK_INT <= Build.VERSION_CODES.KITKAT;

mOutputBuffers = mMediaCodec.getOutputBuffers();

status = MEDIA_CODEC_OUTPUT_BUFFERS_CHANGED;

} else if (indexOrStatus == MediaCodec.INFO_OUTPUT_FORMAT_CHANGED) {