Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index f4ce65c48415f9f7cdbe9a2233c1b3a650a93f03..29f10339ee7137b821ce4bbf0da3b8ff66b8adae 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -78,12 +78,6 @@ class CORE_EXPORT NGConstraintSpace final
NGLogicalOffset Offset() const { return offset_; }
void SetOffset(const NGLogicalOffset& offset) { offset_ = offset; }
- // Returns the effective size of the constraint space. Equal to the
- // AvailableSize() for the root constraint space but derived constraint spaces
- // return the size of the layout opportunity.
- virtual NGLogicalSize Size() const { return size_; }
- void SetSize(const NGLogicalSize& size) { size_ = size; }
-
// Whether the current constraint space is for the newly established
// Formatting Context.
bool IsNewFormattingContext() const;
@@ -117,13 +111,6 @@ class CORE_EXPORT NGConstraintSpace final
DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(physical_space_); }
- // The setters for the NGConstraintSpace should only be used when constructing
- // a derived NGConstraintSpace.
- void SetOverflowTriggersScrollbar(bool inlineTriggers, bool blockTriggers);
- void SetFixedSize(bool inlineFixed, bool blockFixed);
- void SetFragmentationType(NGFragmentationType);
- void SetIsNewFormattingContext(bool is_new_fc);
-
String ToString() const;
private:

Powered by Google App Engine
This is Rietveld 408576698