third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc - Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

index d0682ced648cb755138fbf1f433ac6647ec90f48..78a022e32bc50740efa59bc95ad0e7ff9c858030 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

@@ -29,7 +29,7 @@ NGLayoutOpportunity CreateLayoutOpportunityFromConstraintSpace(

const NGLogicalOffset& origin_point) {

NGLayoutOpportunity opportunity;

opportunity.offset = space.Offset();

- opportunity.size = space.Size();

+ opportunity.size = space.AvailableSize();

cbiesinger 2016/11/18 23:44:23 Why is this correct?

Gleb Lanbin 2016/11/19 04:20:47 Acknowledged.

// adjust to the origin_point.

opportunity.offset += origin_point;