Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 43f71c894f0c5a2ec2a23f3edd503e140262eb1e..27f5322eac5b1a466c7042e068e46f7d3243736d 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -131,45 +131,6 @@ NGLayoutOpportunityIterator* NGConstraintSpace::LayoutOpportunities(
return iterator;
}
-void NGConstraintSpace::SetOverflowTriggersScrollbar(bool inline_triggers,
- bool block_triggers) {
- if (writing_mode_ == HorizontalTopBottom) {
- physical_space_->width_direction_triggers_scrollbar_ = inline_triggers;
- physical_space_->height_direction_triggers_scrollbar_ = block_triggers;
- } else {
- physical_space_->width_direction_triggers_scrollbar_ = block_triggers;
- physical_space_->height_direction_triggers_scrollbar_ = inline_triggers;
- }
-}
-
-void NGConstraintSpace::SetFixedSize(bool inline_fixed, bool block_fixed) {
- if (writing_mode_ == HorizontalTopBottom) {
- physical_space_->fixed_width_ = inline_fixed;
- physical_space_->fixed_height_ = block_fixed;
- } else {
- physical_space_->fixed_width_ = block_fixed;
- physical_space_->fixed_height_ = inline_fixed;
- }
-}
-
-void NGConstraintSpace::SetFragmentationType(NGFragmentationType type) {
- if (writing_mode_ == HorizontalTopBottom) {
- DCHECK_EQ(static_cast<NGFragmentationType>(
- physical_space_->width_direction_fragmentation_type_),
- FragmentNone);
- physical_space_->height_direction_fragmentation_type_ = type;
- } else {
- DCHECK_EQ(static_cast<NGFragmentationType>(
- physical_space_->height_direction_fragmentation_type_),
- FragmentNone);
- physical_space_->width_direction_triggers_scrollbar_ = type;
- }
-}
-
-void NGConstraintSpace::SetIsNewFormattingContext(bool is_new_fc) {
- physical_space_->is_new_fc_ = is_new_fc;
-}
-
String NGConstraintSpace::ToString() const {
return String::format("%s,%s %sx%s",
offset_.inline_offset.toString().ascii().data(),

Powered by Google App Engine
This is Rietveld 408576698