Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2515923002: Remove redundant 'derived constraint space' setters from NGConstraintSpace (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant 'derived constraint space' setters from NGConstraintSpace Remove SetOverflowTriggersScrollbar SetFixedSize SetFragmentationType SetIsNewFormattingContext SetSize Size from NGConstraintSpace. Use NGConstraintSpaceBuilder instead. BUG=635619 Committed: https://crrev.com/2bd351a87b733b8b17f6507adb9b6d0829ca978f Cr-Commit-Position: refs/heads/master@{#433404}

Patch Set 1 #

Total comments: 5

Patch Set 2 : sync to the head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -64 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 3 chunks +2 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (18 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-18 23:39:51 UTC) #2
ikilpatrick
lgtm
4 years, 1 month ago (2016-11-18 23:42:40 UTC) #5
cbiesinger
https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (left): https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#oldcode189 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:189: constraint_space_->SetSize( Why is the new code still correct? This ...
4 years, 1 month ago (2016-11-18 23:44:23 UTC) #7
Gleb Lanbin
https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (left): https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#oldcode189 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:189: constraint_space_->SetSize( On 2016/11/18 23:44:23, cbiesinger wrote: > Why is ...
4 years, 1 month ago (2016-11-19 04:20:47 UTC) #17
cbiesinger
https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (left): https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#oldcode189 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:189: constraint_space_->SetSize( On 2016/11/19 04:20:47, Gleb Lanbin wrote: > On ...
4 years, 1 month ago (2016-11-19 04:28:47 UTC) #18
Gleb Lanbin
On 2016/11/19 04:28:47, cbiesinger wrote: > https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > (left): > > https://codereview.chromium.org/2515923002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#oldcode189 ...
4 years, 1 month ago (2016-11-19 04:44:03 UTC) #21
Gleb Lanbin
On 2016/11/19 04:44:03, Gleb Lanbin wrote: > On 2016/11/19 04:28:47, cbiesinger wrote: > > > ...
4 years, 1 month ago (2016-11-19 05:12:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515923002/40001
4 years, 1 month ago (2016-11-19 05:13:07 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-19 05:18:16 UTC) #26
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2bd351a87b733b8b17f6507adb9b6d0829ca978f Cr-Commit-Position: refs/heads/master@{#433404}
4 years, 1 month ago (2016-11-19 05:21:12 UTC) #28
findit-for-me
FYI: Findit identified this CL at revision 433404 as the culprit for failures in the ...
4 years, 1 month ago (2016-11-19 05:42:53 UTC) #29
sadrul
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2514693004/ by sadrul@chromium.org. ...
4 years, 1 month ago (2016-11-19 06:00:13 UTC) #30
sadrul
On 2016/11/19 06:00:13, sadrul wrote: > A revert of this CL (patchset #2 id:40001) has ...
4 years, 1 month ago (2016-11-19 06:01:38 UTC) #31
cbiesinger
4 years, 1 month ago (2016-11-19 11:02:13 UTC) #32
Message was sent while issue was closed.
Sorry, you are absolutely correct. I didn't realize that
https://chromium.googlesource.com/chromium/src/+/07703ad5e0afd141d4a6da847ffe...
had changed this.

Powered by Google App Engine
This is Rietveld 408576698