Remove redundant 'derived constraint space' setters from NGConstraintSpace

third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
index 0be79a60124f2a4689f8f9ce36211fe82be0290d..cb0df50bf65974e044df96568cd779f53ff57d7b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
@@ -186,9 +186,6 @@ NGLayoutStatus NGBlockLayoutAlgorithm::Layout(
       space_builder_->SetPercentageResolutionSize(
           NGLogicalSize(adjusted_inline_size, adjusted_block_size));
 
-      constraint_space_->SetSize(

[cbiesinger, 2016/11/18 23:44:23]

Why is the new code still correct? This was necessary for correctness...?

[Gleb Lanbin, 2016/11/19 04:20:47]

ConstraintSpace::Size() was only used in
NGLayoutOpportunity::CreateLayoutOpportunityFromConstraintSpace. It always
equals to AvailableSize. So this patch removes redundant Size() method because
we already store the size information in physical constraint space. 

[cbiesinger, 2016/11/19 04:28:47]

So I'm confused. I thought this specific SetSize call was necessary because we
will use constraint_space_ to create the opportunity iterator, and nothing else
makes sure that the size is correct (especially, I don't see a call to set
AvailableSize on constraint_space_). What am I missing...?

-          NGLogicalSize(adjusted_inline_size, adjusted_block_size));
-
       content_size_ = border_and_padding_.block_start;
 
       builder_ = new NGFragmentBuilder(NGPhysicalFragmentBase::FragmentBox);