Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2503993002: Change unique_ptr::reset() for std::move (Closed)

Created:
4 years, 1 month ago by inlinechan
Modified:
4 years ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change unique_ptr::reset() for std::move BUG=644626 R=gavinp@chromium.org Committed: https://crrev.com/894515af61d650d0f2d28445f62eb0ad518e4238 Cr-Commit-Position: refs/heads/master@{#437444}

Patch Set 1 #

Patch Set 2 : Change unique_ptr::reset() for std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M net/cert/x509_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/crypto/channel_id_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/server/http_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/udp_socket_posix.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/udp_socket_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
inlinechan
rebased and ran net_unittests in x86_64 Ubuntu
4 years ago (2016-12-08 05:58:52 UTC) #5
gavinp
lgtm; you may wish another reviewer just because I haven't been in all of these ...
4 years ago (2016-12-08 17:03:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503993002/20001
4 years ago (2016-12-09 01:07:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 02:40:42 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/894515af61d650d0f2d28445f62eb0ad518e4238 Cr-Commit-Position: refs/heads/master@{#437444}
4 years ago (2016-12-09 02:44:06 UTC) #12
inlinechan
4 years ago (2016-12-09 06:43:35 UTC) #13
Message was sent while issue was closed.
Thank you for review.

Powered by Google App Engine
This is Rietveld 408576698