net/quic/core/crypto/quic_crypto_client_config.cc - Issue 2503993002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/crypto/quic_crypto_client_config.cc

Issue 2503993002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change unique_ptr::reset() for std::move Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/core/crypto/quic_crypto_client_config.cc

diff --git a/net/quic/core/crypto/quic_crypto_client_config.cc b/net/quic/core/crypto/quic_crypto_client_config.cc

index a94cbf865ee6f884733e9365c402bc136bb91353..1fd4bd159b4896bd0ce5242e7a1719a70ddfe2d9 100644

--- a/net/quic/core/crypto/quic_crypto_client_config.cc

+++ b/net/quic/core/crypto/quic_crypto_client_config.cc

@@ -180,7 +180,7 @@ QuicCryptoClientConfig::CachedState::SetServerConfig(StringPiece server_config,

if (!matches_existing) {

server_config_ = server_config.as_string();

SetProofInvalid();

- scfg_.reset(new_scfg_storage.release());

+ scfg_ = std::move(new_scfg_storage);

}

return SERVER_CONFIG_VALID;

}