net/quic/chromium/crypto/channel_id_chromium.cc - Issue 2503993002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/crypto/channel_id_chromium.cc

Issue 2503993002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change unique_ptr::reset() for std::move Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/crypto/channel_id_chromium.cc

diff --git a/net/quic/chromium/crypto/channel_id_chromium.cc b/net/quic/chromium/crypto/channel_id_chromium.cc

index 164e1e5841e8029f38b037f1377a8179d14f9e05..f91f466aa8cac1a232afe90278c34a597e12a722 100644

--- a/net/quic/chromium/crypto/channel_id_chromium.cc

+++ b/net/quic/chromium/crypto/channel_id_chromium.cc

@@ -128,7 +128,7 @@ QuicAsyncStatus ChannelIDSourceChromium::Job::GetChannelIDKey(

next_state_ = STATE_GET_CHANNEL_ID_KEY;

switch (DoLoop(OK)) {

case OK:

- channel_id_key->reset(channel_id_key_.release());

+ *channel_id_key = std::move(channel_id_key_);

return QUIC_SUCCESS;

case ERR_IO_PENDING:

callback_.reset(callback);