net/disk_cache/simple/simple_entry_impl.cc - Issue 2503993002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_entry_impl.cc

Issue 2503993002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change unique_ptr::reset() for std::move Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_entry_impl.cc

diff --git a/net/disk_cache/simple/simple_entry_impl.cc b/net/disk_cache/simple/simple_entry_impl.cc

index 8bc20fcbbde95e5d1f7611e90370fd4b64712d71..23136ba60e541c91b9d5cfccfe0bffb1651df214 100644

--- a/net/disk_cache/simple/simple_entry_impl.cc

+++ b/net/disk_cache/simple/simple_entry_impl.cc

@@ -205,7 +205,7 @@ SimpleEntryImpl::SimpleEntryImpl(net::CacheType cache_type,

void SimpleEntryImpl::SetActiveEntryProxy(

std::unique_ptr<ActiveEntryProxy> active_entry_proxy) {

DCHECK(!active_entry_proxy_);

- active_entry_proxy_.reset(active_entry_proxy.release());

+ active_entry_proxy_ = std::move(active_entry_proxy);

}

int SimpleEntryImpl::OpenEntry(Entry** out_entry,

« no previous file with comments | « net/cert/x509_util.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »