net/proxy/proxy_config_service_linux.cc - Issue 2503993002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config_service_linux.cc

Issue 2503993002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change unique_ptr::reset() for std::move Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_config_service_linux.cc

diff --git a/net/proxy/proxy_config_service_linux.cc b/net/proxy/proxy_config_service_linux.cc

index 71d43a1706ec9cc1e409f23b3f15d0b2ccc767c4..f0f03dc42abbe3bf07f24d5391ca2f393f4ce8f2 100644

--- a/net/proxy/proxy_config_service_linux.cc

+++ b/net/proxy/proxy_config_service_linux.cc

@@ -1548,7 +1548,7 @@ ProxyConfigServiceLinux::Delegate::Delegate(

// We have to load symbols and check the GNOME version in use to decide

// if we should use the gsettings getter. See LoadAndCheckVersion().

if (gs_getter->LoadAndCheckVersion(env_var_getter_.get()))

- setting_getter_.reset(gs_getter.release());

+ setting_getter_ = std::move(gs_getter);

}

#endif

#if defined(USE_GCONF)