Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, jam, yusukes+watch_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, dcheng, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, arv+watch_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, extensions-reviews_chromium.org, maniscalco+watch-blimp_chromium.org, mlamouri+watch-geolocation_chromium.org, bgoldman+watch-blimp_chromium.org, achuith+watch_chromium.org, gcasto+watch-blimp_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, vabr+watchlistlogin_chromium.org, lethalantidote+watch-blimp_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, scf+watch-blimp_chromium.org, blink-worker-reviews_chromium.org, dbeam+watch-options_chromium.org, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, kalyank, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, James Su, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, davemoore+watch_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after https://crrev.com/2478803003. BUG=662543 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Rebasing... #

Patch Set 5 : Rebasing... #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : Fix nacl_browsertest_util.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -261 lines) Patch
M chrome/browser/chrome_service_worker_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 4 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 3 4 5 6 7 5 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/merge_session_load.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/neterror.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/site_per_process_interactive_browsertest.cc View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_interstitial_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/data/ads_observer/docwrite_provisional_frame.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/automation/sends_message_on_load.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/chrome_extension_resource.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/drag_and_drop/event_monitoring.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/canvas_popup.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/gpu/feature_canvas2d.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_multisampling.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_raf_no_damage.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_webgl.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/webgl_conformance.html View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/gpu/webgl_popup.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/keyevents_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/local_ntp_browsertest.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/nacl/load_util.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/nacl/nonsfi/libc_free.html View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/nacl/pnacl_mime_type/pnacl_mime_type.html View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/nacl/pnacl_url_loader/pnacl_url_loader.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/page_with_focus_events.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/password/frame_detached_on_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/password/password_fetch_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/password/password_xhr_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/popup_iframe.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/supervised_user/with_iframes.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/tab-restore-visibility.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -13 lines 0 comments Download
M components/security_interstitials/core/common/resources/interstitial_common.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/supervised_user_error_page/resources/supervised_user_block_interstitial.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/zoom_browsertest.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -13 lines 0 comments Download
M content/renderer/dom_automation_controller.h View 1 3 chunks +9 lines, -67 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 2 3 4 5 3 chunks +2 lines, -19 lines 0 comments Download
M content/test/data/cross_site_document_request.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/fullscreen_frame.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/concave_paths.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/filter_effects.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/functional_3d_css.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/functional_canvas_demo.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/functional_files/context.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/functional_video.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_background.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_browser_plugin.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_canvas2d.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_canvas2d_accelerated.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_canvas2d_untagged.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_canvas2d_webgl.html View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/test/data/gpu/pixel_canvas_display_linear-rgb.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_css3d.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_2d_resize_on_worker.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_main.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_transferToImageBitmap_worker.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_transfer_after_style_resize.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_transfer_before_style_resize.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_resize_on_worker.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_scissor.html View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/data/gpu/pixel_video_mp4.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_video_vp9.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_webgl_noalpha_implicit_clear.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/gpu/pixel_webgl_util.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/data/gpu/webgl.html View 4 chunks +0 lines, -8 lines 0 comments Download
M content/test/data/net_info.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/page_with_blur.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/page_with_input_field.html View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/post_message.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/resource_loading/resource_loading_non_mobile.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/simple_database.html View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/context_lost_integration_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/depth_capture_integration_test.py View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel_integration_test.py View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/trace_integration_test.py View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/native_client/tools/browser_tester/browserdata/nacltest.js View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_case.html View 1 chunk +1 line, -3 lines 0 comments Download
M ui/webui/resources/js/webui_resource_test.js View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (37 generated)
Łukasz Anforowicz
Description was changed from ========== Remove all calls to domAutomationController.setAutomationId. These calls are no longer ...
4 years, 1 month ago (2016-11-14 23:57:59 UTC) #1
Łukasz Anforowicz
Description was changed from ========== Remove all calls to domAutomationController.setAutomationId. These calls are no longer ...
4 years, 1 month ago (2016-11-14 23:58:00 UTC) #2
Łukasz Anforowicz
Description was changed from ========== Remove all calls to domAutomationController.setAutomationId. These calls are no longer ...
4 years, 1 month ago (2016-11-14 23:58:01 UTC) #3
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-14 23:59:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/1
4 years, 1 month ago (2016-11-15 00:00:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-15 01:20:17 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/314621)
4 years, 1 month ago (2016-11-15 01:20:18 UTC) #7
Michael van Ouwerkerk
Description was changed from ========== Remove all calls to domAutomationController.setAutomationId. These calls are no longer ...
3 years, 8 months ago (2017-04-13 10:55:52 UTC) #8
Łukasz Anforowicz
Description was changed from ========== Remove all calls to domAutomationController.setAutomationId. These calls are no longer ...
3 years, 6 months ago (2017-06-20 22:26:58 UTC) #9
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-26 16:21:36 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/40001
3 years, 5 months ago (2017-06-26 16:21:48 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-26 16:25:47 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/245764) mac_optional_gpu_tests_rel on ...
3 years, 5 months ago (2017-06-26 16:25:48 UTC) #13
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 21:09:11 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/80001
3 years, 5 months ago (2017-07-06 21:09:24 UTC) #15
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 21:17:03 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/100001
3 years, 5 months ago (2017-07-06 21:17:31 UTC) #17
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 21:18:55 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/120001
3 years, 5 months ago (2017-07-06 21:19:12 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 21:30:13 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/12274)
3 years, 5 months ago (2017-07-06 21:30:15 UTC) #21
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 21:37:00 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/120001
3 years, 5 months ago (2017-07-06 21:37:14 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 22:42:20 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/493846)
3 years, 5 months ago (2017-07-06 22:42:22 UTC) #25
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 22:47:10 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/120001
3 years, 5 months ago (2017-07-06 22:47:25 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 22:57:03 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/495226)
3 years, 5 months ago (2017-07-06 22:57:04 UTC) #29
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-07 17:01:45 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/120001
3 years, 5 months ago (2017-07-07 17:01:55 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-07 17:58:48 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/463525)
3 years, 5 months ago (2017-07-07 17:58:50 UTC) #33
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-11 14:41:54 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453003/140001
3 years, 5 months ago (2017-07-11 14:42:14 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-11 15:23:20 UTC) #36
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 15:23:21 UTC) #37 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698