chrome/browser/devtools/devtools_sanity_browsertest.cc - Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.

Patch Set: Fix nacl_browsertest_util.cc Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_sanity_browsertest.cc

diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc

index 7da9f3b7b39f11cdea4ebf483d50c5c591e98b3c..7183194eda92e2a0842b4aeea06a0885d4cf59e3 100644

--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc

+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc

@@ -1531,7 +1531,6 @@ IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

"var xhr = new XMLHttpRequest();\n"

"xhr.open('GET', blob_url, true);\n"

"xhr.onload = function (e) {\n"

- " domAutomationController.setAutomationId(0);\n"

" domAutomationController.send(xhr.response);\n"

"};\n"

"xhr.send(null);\n");

@@ -1540,7 +1539,6 @@ IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,

"var payload = `"

"<html><body>iframe blob contents"

"<script>"

- " domAutomationController.setAutomationId(0);"

" domAutomationController.send(document.body.innerText);\n"

"</script></body></html>"

"`;"