chrome/browser/chromeos/login/kiosk_browsertest.cc - Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/kiosk_browsertest.cc

Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.

Patch Set: Fix nacl_browsertest_util.cc Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc ('k') | chrome/browser/chromeos/login/login_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/kiosk_browsertest.cc

diff --git a/chrome/browser/chromeos/login/kiosk_browsertest.cc b/chrome/browser/chromeos/login/kiosk_browsertest.cc

index 4813f64230f49511ca2b3b6a7333f434b3536632..4d2446d7e2e25fd4c129b89d82a01e0a2311b098 100644

--- a/chrome/browser/chromeos/login/kiosk_browsertest.cc

+++ b/chrome/browser/chromeos/login/kiosk_browsertest.cc

@@ -843,7 +843,6 @@ IN_PROC_BROWSER_TEST_F(KioskTest, ZoomSupport) {

int original_width;

EXPECT_TRUE(content::ExecuteScriptAndExtractInt(

window->web_contents(),

- "window.domAutomationController.setAutomationId(0);"

"window.domAutomationController.send(window.innerWidth);",

&original_width));

@@ -859,7 +858,6 @@ IN_PROC_BROWSER_TEST_F(KioskTest, ZoomSupport) {

int width_zoomed_in;

EXPECT_TRUE(content::ExecuteScriptAndExtractInt(

window->web_contents(),

- "window.domAutomationController.setAutomationId(0);"

"window.domAutomationController.send(window.innerWidth);",

&width_zoomed_in));

DCHECK_LT(width_zoomed_in, original_width);

@@ -870,7 +868,6 @@ IN_PROC_BROWSER_TEST_F(KioskTest, ZoomSupport) {

int width_zoom_normal;

EXPECT_TRUE(content::ExecuteScriptAndExtractInt(

window->web_contents(),

- "window.domAutomationController.setAutomationId(0);"

"window.domAutomationController.send(window.innerWidth);",

&width_zoom_normal));

DCHECK_EQ(width_zoom_normal, original_width);

@@ -881,7 +878,6 @@ IN_PROC_BROWSER_TEST_F(KioskTest, ZoomSupport) {

int width_zoomed_out;

EXPECT_TRUE(content::ExecuteScriptAndExtractInt(

window->web_contents(),

- "window.domAutomationController.setAutomationId(0);"

"window.domAutomationController.send(window.innerWidth);",

&width_zoomed_out));

DCHECK_GT(width_zoomed_out, original_width);

@@ -2229,7 +2225,6 @@ IN_PROC_BROWSER_TEST_F(KioskEnterpriseTest, EnterpriseKioskApp) {

EXPECT_TRUE(content::ExecuteScriptAndExtractString(

window->web_contents(),

"chrome.identity.getAuthToken({ 'interactive': false }, function(token) {"

- " window.domAutomationController.setAutomationId(0);"

" window.domAutomationController.send(token);"

"});",

&result));