Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: content/renderer/dom_automation_controller.cc

Issue 2503453003: Remove all calls to domAutomationController.setAutomationId.
Patch Set: Fix nacl_browsertest_util.cc Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/dom_automation_controller.h ('k') | content/test/data/cross_site_document_request.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/dom_automation_controller.cc
diff --git a/content/renderer/dom_automation_controller.cc b/content/renderer/dom_automation_controller.cc
index e3d35046c1eb41da4a8f7c0566d71a23ade55b25..590388383f8778a9c01ecb4a924e4f6b6f61d95a 100644
--- a/content/renderer/dom_automation_controller.cc
+++ b/content/renderer/dom_automation_controller.cc
@@ -51,9 +51,7 @@ gin::ObjectTemplateBuilder DomAutomationController::GetObjectTemplateBuilder(
return gin::Wrappable<DomAutomationController>::GetObjectTemplateBuilder(
isolate)
.SetMethod("send", &DomAutomationController::SendMsg)
- .SetMethod("setAutomationId", &DomAutomationController::SetAutomationId)
- .SetMethod("sendJSON", &DomAutomationController::SendJSON)
- .SetMethod("sendWithId", &DomAutomationController::SendWithId);
+ .SetMethod("sendJSON", &DomAutomationController::SendJSON);
}
void DomAutomationController::OnDestruct() {}
@@ -106,10 +104,7 @@ bool DomAutomationController::SendMsg(const gin::Arguments& args) {
if (!value || !serializer.Serialize(*value))
return false;
- bool succeeded = Send(new FrameHostMsg_DomOperationResponse(
- routing_id(), json));
-
- return succeeded;
+ return SendJSON(json);
}
bool DomAutomationController::SendJSON(const std::string& json) {
@@ -122,16 +117,4 @@ bool DomAutomationController::SendJSON(const std::string& json) {
return result;
}
-bool DomAutomationController::SendWithId(int automation_id,
- const std::string& str) {
- if (!render_frame())
- return false;
- return Send(
- new FrameHostMsg_DomOperationResponse(routing_id(), str));
-}
-
-bool DomAutomationController::SetAutomationId(int automation_id) {
- return true;
-}
-
} // namespace content
« no previous file with comments | « content/renderer/dom_automation_controller.h ('k') | content/test/data/cross_site_document_request.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698