Fix bug of animated table col/section/row background

Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG=665238
TEST=paint/invalidation/table/animated-row-background.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b
Cr-Commit-Position: refs/heads/master@{#432380}

[Xianzhu, 2016-11-15 00:59:43]

Description was changed from

==========
Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG=665238
TEST=paint/invalidation/table/animated-row-background.html
==========

to

==========
Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG=665238
TEST=paint/invalidation/table/animated-row-background.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-11-15 00:59:44]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-15 03:05:20]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[Xianzhu, 2016-11-15 03:05:20]

@wkorman this happens to be an example of calling
ensureIsReadyForPaintInvalidation() before walking into the tree.

[Xianzhu, 2016-11-15 03:12:06]

I'm thinking of how animated background of LayoutInline is handled. Looking into
if we should move some code handling animated background from LayoutBox into
LayoutBoxModelObject.

[Xianzhu, 2016-11-15 03:18:20]

On 2016/11/15 03:12:06, Xianzhu wrote:
> I'm thinking of how animated background of LayoutInline is handled. Looking
into
> if we should move some code handling animated background from LayoutBox into
> LayoutBoxModelObject.

We have LayoutInline::imageChanged() covering background change. Would like to
keep this CL LayoutBox only, and address LayoutBoxModelObject in a later CL.

[commit-bot: I haz the power, 2016-11-15 03:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:19:33]

Dry run: This issue passed the CQ dry run.

[wkorman, 2016-11-15 18:45:11]

lgtm

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html
(right):

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html:24:
console.log("onload");
rm

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html:26:
image.src="../../../fast/backgrounds/resources/red-green-animated.gif";
Why does the test need both this animated image in the #image element, and on
the table row background? The former seems like maybe it is just for debugging
purposes and not intended to be left in?

[Xianzhu, 2016-11-15 18:52:29]

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html
(right):

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html:24:
console.log("onload");
On 2016/11/15 18:45:11, wkorman wrote:
> rm

Done.

https://codereview.chromium.org/2501833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html:26:
image.src="../../../fast/backgrounds/resources/red-green-animated.gif";
On 2016/11/15 18:45:11, wkorman wrote:
> Why does the test need both this animated image in the #image element, and on
> the table row background? The former seems like maybe it is just for debugging
> purposes and not intended to be left in?

The <img> element has two purposes:
1. ensures that the test runs just after the image is loaded;
2. is passed to internals.advanceImageAnimation() which requires an img element.

[Xianzhu, 2016-11-15 18:55:16]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-15 18:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2501833002/#ps10001
(title: "-")

[commit-bot: I haz the power, 2016-11-15 18:56:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:38:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-11-15 20:52:35]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-15 20:52:35]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2501833002/#ps30001
(title: "-")

[commit-bot: I haz the power, 2016-11-15 20:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:13:41]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2016-11-15 21:59:57]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:27:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:27:16]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2016-11-15 22:32:47]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:33:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:03:25]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2016-11-16 03:16:52]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:17:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 06:16:57]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-11-16 06:18:57]

Description was changed from

==========
Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG=665238
TEST=paint/invalidation/table/animated-row-background.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG=665238
TEST=paint/invalidation/table/animated-row-background.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b
Cr-Commit-Position: refs/heads/master@{#432380}
==========

[commit-bot: I haz the power, 2016-11-16 06:18:58]

Patchset 3 (id:??) landed as
https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b
Cr-Commit-Position: refs/heads/master@{#432380}