Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h

Issue 2501833002: Fix bug of animated table col/section/row background (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
index b19c36818d6d3f3e162d6029fe91aa6f70f36346..d5b97199af8b343d99a162dc15fc421f3bbfb367 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
@@ -15,21 +15,13 @@ class LayoutTable;
// Common super class for LayoutTableCol, LayoutTableSection and LayoutTableRow.
class CORE_EXPORT LayoutTableBoxComponent : public LayoutBox {
public:
- bool backgroundChangedSinceLastPaintInvalidation() const {
- return m_backgroundChangedSinceLastPaintInvalidation;
- }
- void clearBackgroundChangedSinceLastPaintInvalidation() {
- m_backgroundChangedSinceLastPaintInvalidation = false;
- }
static bool doCellsHaveDirtyWidth(const LayoutObject& tablePart,
const LayoutTable&,
const StyleDifference&,
const ComputedStyle& oldStyle);
protected:
- explicit LayoutTableBoxComponent(Element* element)
- : LayoutBox(element),
- m_backgroundChangedSinceLastPaintInvalidation(false) {}
+ explicit LayoutTableBoxComponent(Element* element) : LayoutBox(element) {}
const LayoutObjectChildList* children() const { return &m_children; }
LayoutObjectChildList* children() { return &m_children; }
@@ -43,21 +35,6 @@ class CORE_EXPORT LayoutTableBoxComponent : public LayoutBox {
return children()->lastChild();
}
- void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;
- void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
-
- void clearPaintInvalidationFlags() override {
- LayoutBox::clearPaintInvalidationFlags();
- m_backgroundChangedSinceLastPaintInvalidation = false;
- }
-
-#if ENABLE(ASSERT)
- bool paintInvalidationStateIsDirty() const override {
- return m_backgroundChangedSinceLastPaintInvalidation ||
- LayoutBox::paintInvalidationStateIsDirty();
- }
-#endif
-
private:
// If you have a LayoutTableBoxComponent, use firstChild or lastChild instead.
void slowFirstChild() const = delete;
@@ -69,7 +46,6 @@ class CORE_EXPORT LayoutTableBoxComponent : public LayoutBox {
}
LayoutObjectChildList m_children;
- bool m_backgroundChangedSinceLastPaintInvalidation;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698