Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Issue 2501833002: Fix bug of animated table col/section/row background (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
index ae42aec7653bb485b37f094488470f9829c2f779..83b770615fdf4e52e4ad12b30e70ad62e6f4f394 100644
--- a/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
@@ -28,6 +28,9 @@ PaintInvalidationReason TablePaintInvalidator::invalidatePaintIfNeeded() {
bool hasColChangedBackground = false;
for (LayoutTableCol* col = m_table.firstColumn(); col;
col = col->nextColumn()) {
+ // This ensures that the backgroundChangedSinceLastPaintInvalidation flag
+ // is up-to-date.
+ col->ensureIsReadyForPaintInvalidation();
if (col->backgroundChangedSinceLastPaintInvalidation()) {
hasColChangedBackground = true;
break;
@@ -38,12 +41,14 @@ PaintInvalidationReason TablePaintInvalidator::invalidatePaintIfNeeded() {
if (!child->isTableSection())
continue;
LayoutTableSection* section = toLayoutTableSection(child);
+ section->ensureIsReadyForPaintInvalidation();
ObjectPaintInvalidator sectionInvalidator(*section);
if (!hasColChangedBackground &&
!section
->shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState())
continue;
for (LayoutTableRow* row = section->firstRow(); row; row = row->nextRow()) {
+ row->ensureIsReadyForPaintInvalidation();
if (!hasColChangedBackground &&
!section->backgroundChangedSinceLastPaintInvalidation() &&
!row->backgroundChangedSinceLastPaintInvalidation())
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698