Fix bug of animated table col/section/row background

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1658 matching lines @@
   // Painters can use const methods only, except for these explicitly declared
   // methods.
   class MutableForPainting {
    public:
     void clearPaintInvalidationFlags() {
       m_layoutObject.clearPaintInvalidationFlags();
     }
     void setShouldDoFullPaintInvalidation(PaintInvalidationReason reason) {
       m_layoutObject.setShouldDoFullPaintInvalidation(reason);
     }
+    void setBackgroundChangedSinceLastPaintInvalidation() {
+      m_layoutObject.setBackgroundChangedSinceLastPaintInvalidation();
+    }
     void ensureIsReadyForPaintInvalidation() {
       m_layoutObject.ensureIsReadyForPaintInvalidation();
     }
 
     void setPreviousVisualRect(const LayoutRect& r) {
       m_layoutObject.setPreviousVisualRect(r);
     }
     void setPreviousPaintOffset(const LayoutPoint& p) {
       DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
       m_layoutObject.m_previousPaintOffset = p;
@@ skipping 96 matching lines @@
   bool hasPreviousLocationInBacking() const {
     return m_bitfields.hasPreviousLocationInBacking();
   }
   bool hasPreviousSelectionVisualRect() const {
     return m_bitfields.hasPreviousSelectionVisualRect();
   }
   bool hasPreviousBoxGeometries() const {
     return m_bitfields.hasPreviousBoxGeometries();
   }
 
+  bool backgroundChangedSinceLastPaintInvalidation() const {
+    return m_bitfields.backgroundChangedSinceLastPaintInvalidation();
+  }
+  void setBackgroundChangedSinceLastPaintInvalidation() {
+    m_bitfields.setBackgroundChangedSinceLastPaintInvalidation(true);
+  }
+
  protected:
   enum LayoutObjectType {
     LayoutObjectBr,
     LayoutObjectCanvas,
     LayoutObjectFieldset,
     LayoutObjectCounter,
     LayoutObjectDetailsMarker,
     LayoutObjectEmbeddedObject,
     LayoutObjectFileUploadControl,
     LayoutObjectFrame,
@@ skipping 113 matching lines @@
   // Add hit-test rects for this layoutObject only to the provided list.
   // layerOffset is the offset of this layoutObject within the current layer
   // that should be used for each result.
   virtual void computeSelfHitTestRects(Vector<LayoutRect>&,
                                        const LayoutPoint& layerOffset) const {}
 
   void setPreviousVisualRect(const LayoutRect& rect) {
     m_previousVisualRect = rect;
   }
 
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
   virtual bool paintInvalidationStateIsDirty() const {
-    return shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState();
+    return backgroundChangedSinceLastPaintInvalidation() ||
+           shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState();
   }
 #endif
 
   // Called before paint invalidation.
   virtual void ensureIsReadyForPaintInvalidation() { DCHECK(!needsLayout()); }
 
   // This function walks the descendants of |this|, following a
   // layout ordering.
   //
   // The ordering is important for PaintInvalidationState, as it requires to be
@@ skipping 187 matching lines @@
           m_alwaysCreateLineBoxesForLayoutInline(false),
           m_previousBackgroundObscured(false),
           m_isBackgroundAttachmentFixedObject(false),
           m_isScrollAnchorObject(false),
           m_scrollAnchorDisablingStyleChanged(false),
           m_hasBoxDecorationBackground(false),
           m_hasPreviousLocationInBacking(false),
           m_hasPreviousSelectionVisualRect(false),
           m_hasPreviousBoxGeometries(false),
           m_needsPaintPropertyUpdate(true),
+          m_backgroundChangedSinceLastPaintInvalidation(false),
           m_positionedState(IsStaticallyPositioned),
           m_selectionState(SelectionNone),
           m_backgroundObscurationState(BackgroundObscurationStatusInvalid),
           m_fullPaintInvalidationReason(PaintInvalidationNone) {}
 
     // Self needs layout means that this layout object is marked for a full
     // layout. This is the default layout but it is expensive as it recomputes
     // everything. For CSS boxes, this includes the width (laying out the line
     // boxes again), the margins (due to block collapsing margins), the
     // positions, the height and the potential overflow.
@@ skipping 152 matching lines @@
     ADD_BOOLEAN_BITFIELD(hasPreviousLocationInBacking,
                          HasPreviousLocationInBacking);
     ADD_BOOLEAN_BITFIELD(hasPreviousSelectionVisualRect,
                          HasPreviousSelectionVisualRect);
     ADD_BOOLEAN_BITFIELD(hasPreviousBoxGeometries, HasPreviousBoxGeometries);
 
     // Whether the paint properties need to be updated. For more details, see
     // LayoutObject::needsPaintPropertyUpdate().
     ADD_BOOLEAN_BITFIELD(needsPaintPropertyUpdate, NeedsPaintPropertyUpdate);
 
+    ADD_BOOLEAN_BITFIELD(backgroundChangedSinceLastPaintInvalidation,
+                         BackgroundChangedSinceLastPaintInvalidation);
+
    protected:
     // Use protected to avoid warning about unused variable.
-    unsigned m_unusedBits : 9;
+    unsigned m_unusedBits : 8;
 
    private:
     // This is the cached 'position' value of this object
     // (see ComputedStyle::position).
     unsigned m_positionedState : 2;  // PositionedState
     unsigned m_selectionState : 3;   // SelectionState
     // Mutable for getter which lazily update this field.
     mutable unsigned
         m_backgroundObscurationState : 2;        // BackgroundObscurationState
     unsigned m_fullPaintInvalidationReason : 5;  // PaintInvalidationReason
@@ skipping 304 matching lines @@
 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
                                 const blink::LayoutObject* object2);
 
 #endif
 
 #endif  // LayoutObject_h