third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html - Issue 2501833002: Fix bug of animated table col/section/row background

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html

Issue 2501833002: Fix bug of animated table col/section/row background (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 td { width: 100px; height: 100px }

	4 tr { background-image: url(../../../fast/backgrounds/resources/red-green-animate d.gif) }

	5 </style>

	6 <table>

	7 <tr id="row">

	8 <td id="cell1"></td>

	9 <td id="cell2"></td>

	10 </tr>

	11 </table>

	12 <img id="image">

	13 <script src="../resources/text-based-repaint.js"></script>

	14 <script>

	15 window.testIsAsync = true;

	16 function repaintTest() {

	17 if (window.internals)

	18 internals.advanceImageAnimation(image);

	19 requestAnimationFrame(function() {

	20 finishRepaintTest();

	21 });

	22 }

	23 onload = function() {

	24 console.log("onload");
	wkorman 2016/11/15 18:45:11 rm rm Xianzhu 2016/11/15 18:52:29 Done. Show quoted text On 2016/11/15 18:45:11, wkorman wrote: > rm Done.
	25 image.onload = runRepaintTest;

	26 image.src="../../../fast/backgrounds/resources/red-green-animated.gif";
	wkorman 2016/11/15 18:45:11 Why does the test need both this animated image in Why does the test need both this animated image in the #image element, and on the table row background? The former seems like maybe it is just for debugging purposes and not intended to be left in? Xianzhu 2016/11/15 18:52:29 The <img> element has two purposes: 1. ensures tha Show quoted text On 2016/11/15 18:45:11, wkorman wrote: > Why does the test need both this animated image in the #image element, and on > the table row background? The former seems like maybe it is just for debugging > purposes and not intended to be left in? The <img> element has two purposes: 1. ensures that the test runs just after the image is loaded; 2. is passed to internals.advanceImageAnimation() which requires an img element.
	27 }

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background-expected.txt » ('j') | no next file with comments »