Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2501793002: Prevent the browser from crashing when exiting pages that use WebVR. (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent the browser from crashing when exiting pages that use WebVR. BUG=389343 Committed: https://crrev.com/6587a215160cf4b079ce5d37ce695b7f9cdc6851 Cr-Commit-Position: refs/heads/master@{#432247}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M device/vr/vr_display_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_display_impl.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
bajones
Fixes a couple of different sources of crashes when leaving WebVR pages. PTAL!
4 years, 1 month ago (2016-11-15 01:55:20 UTC) #2
mthiesse
lgtm
4 years, 1 month ago (2016-11-15 15:11:19 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2499793002 Patch 20001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-15 16:30:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501793002/1
4 years, 1 month ago (2016-11-15 17:06:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/335645)
4 years, 1 month ago (2016-11-15 17:09:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501793002/20001
4 years, 1 month ago (2016-11-15 17:51:29 UTC) #13
klausw (use chromium instead)
On 2016/11/15 01:55:20, bajones wrote: > Fixes a couple of different sources of crashes when ...
4 years, 1 month ago (2016-11-15 18:10:29 UTC) #14
klausw
On 2016/11/15 18:10:29, klausw (use chromium instead) wrote: > On 2016/11/15 01:55:20, bajones wrote: > ...
4 years, 1 month ago (2016-11-15 18:11:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 20:45:28 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:55:44 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6587a215160cf4b079ce5d37ce695b7f9cdc6851
Cr-Commit-Position: refs/heads/master@{#432247}

Powered by Google App Engine
This is Rietveld 408576698