device/vr/vr_display_impl.h - Issue 2501793002: Prevent the browser from crashing when exiting pages that use WebVR.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/vr/vr_display_impl.h

Issue 2501793002: Prevent the browser from crashing when exiting pages that use WebVR. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « device/vr/android/gvr/gvr_device_provider.cc ('k') | device/vr/vr_display_impl.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DEVICE_VR_VR_DISPLAY_IMPL_H	5 #ifndef DEVICE_VR_VR_DISPLAY_IMPL_H

6 #define DEVICE_VR_VR_DISPLAY_IMPL_H	6 #define DEVICE_VR_VR_DISPLAY_IMPL_H

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 22 matching lines...) Expand all Loading...
33 const RequestPresentCallback& callback) override;	33 const RequestPresentCallback& callback) override;

34 void ExitPresent() override;	34 void ExitPresent() override;

35 void SubmitFrame(mojom::VRPosePtr pose) override;	35 void SubmitFrame(mojom::VRPosePtr pose) override;

36	36

37 void UpdateLayerBounds(mojom::VRLayerBoundsPtr left_bounds,	37 void UpdateLayerBounds(mojom::VRLayerBoundsPtr left_bounds,

38 mojom::VRLayerBoundsPtr right_bounds) override;	38 mojom::VRLayerBoundsPtr right_bounds) override;

39	39

40 mojo::Binding<mojom::VRDisplay> binding_;	40 mojo::Binding<mojom::VRDisplay> binding_;

41 mojom::VRDisplayClientPtr client_;	41 mojom::VRDisplayClientPtr client_;

42 device::VRDevice* device_;	42 device::VRDevice* device_;

43 std::unique_ptr<VRServiceImpl> service_;	43 VRServiceImpl* service_;

44 };	44 };

45	45

46 } // namespace device	46 } // namespace device

47	47

48 #endif // DEVICE_VR_VR_DISPLAY_IMPL_H	48 #endif // DEVICE_VR_VR_DISPLAY_IMPL_H

OLD	NEW