Issue 2499793002: Refactoring how WebVR eye bounds are handled

Issue 2499793002: Refactoring how WebVR eye bounds are handled (Closed)

Created:
4 years, 1 month ago by bajones

Modified:
4 years, 1 month ago

Reviewers:
klausw, mthiesse

CC:
chromium-reviews, blink-reviews, haraken

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactoring how WebVR eye bounds are handled BUG=389343 Committed: https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce Cr-Commit-Position: refs/heads/master@{#432198}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -85 lines)			Patch
M	chrome/browser/android/vr_shell/vr_shell.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell.cc	View	1 2	3 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell_delegate.cc	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell_renderer.h	View		1 chunk	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/android/vr_shell/vr_shell_renderer.cc	View		5 chunks	+12 lines, -40 lines	0 comments	Download
M	device/vr/android/gvr/gvr_delegate.h	View	1 2	1 chunk	+3 lines, -5 lines	0 comments	Download
M	device/vr/android/gvr/gvr_device.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	device/vr/android/gvr/gvr_device.cc	View	1 2	1 chunk	+15 lines, -8 lines	0 comments	Download
M	device/vr/vr_device.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	device/vr/vr_display_impl.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	device/vr/vr_display_impl.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/vr/VRDisplay.cpp	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download

Dependent Patchsets:

Total messages: 8 (3 generated)

bajones

Handling layer bounds was pretty thoroughly broken in previous GVR builds. This fixes how they're ...

4 years, 1 month ago (2016-11-14 20:31:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499793002/40001

4 years, 1 month ago (2016-11-15 15:25:10 UTC) #5

commit-bot: I haz the power

4 years, 1 month ago (2016-11-15 17:31:41 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/b93c3a787b003a8720a585e58c842505fe54f6ce
Cr-Commit-Position: refs/heads/master@{#432198}